Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla-Plugin-ShareDir-Tarball CPAN distribution.

Report information
The Basics
Id: 83777
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-ShareDir-Tarball

People
Owner: Nobody in particular
Requestors: NGLENN [...] cpan.org
Cc: garfieldnate [...] gmail.com
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



CC: garfieldnate [...] gmail.com
Subject: documentation/option on tarball output location
Since you added the option to choose the input directory, I think you need another addition to the documentation. "The tarball is always created in a directory named 'share', regardless of the name of the directory of the input files. Therefore, the default argument to the 'dir' option of L<Dist::Zilla::Plugin::ShareDir] is the correct one." On the other hand, you might just want to add another option to specify the output directory, or to keep the same directory name or not. I was surprised that the tarball was put in the "share/" directory when I used this, but it turned out to be very nice for my project.
RT-Send-CC: garfieldnate [...] gmail.com
Hmm, this is actually turning out to be really bad because DZP::Sharedir doesn't runs before DZP::ShareDir::Tarball, and so doesn't see a 'share' directory yet. Since there aren't any matching files, it just ignores it and the files aren't installed. This is actually a bug, not a wishlist or documentation problem. DZPST either needs to run before DZPS (which I would like better), or it needs to put the tarball back into the same directory. On Tue Mar 05 18:52:48 2013, NGLENN wrote: Show quoted text
> but it turned out to be very nice for my project.
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Tue, 05 Mar 2013 19:36:57 -0500
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 13-03-05 06:52 PM, Nathan Gary Glenn via RT wrote: Show quoted text
> On the other hand, you might just want to add another option to specify > the output directory, or to keep the same directory name or not. I was > surprised that the tarball was put in the "share/" directory when I used > this, but it turned out to be very nice for my project.
In the case of all ShareDir modules, the output directory is generally 'share', as this is also the location where it will be installed on the system. Whereas I can see reasons to have the source be somewhere else than 'share/', I'm not so sure about the output directory. Joy, `/anick
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Tue, 05 Mar 2013 19:38:20 -0500
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 13-03-05 07:16 PM, Nathan Gary Glenn via RT wrote: Show quoted text
> This is actually a bug, not a wishlist or documentation problem. DZPST > either needs to run before DZPS (which I would like better), or it needs > to put the tarball back into the same directory.
The order in which plugins are running are dictated by the order in which they appear in your dist.ini. So, in theory, you just have to make sure that DZPS appears after DZPST, and everything should be good. Joy, `/anick
RT-Send-CC: garfieldnate [...] gmail.com, yanick [...] babyl.dyndns.org
I tried reordering and it didn't work. Is there a way to reorder phases? I added some printouts, and combined with '[ReportPhase / Phase_Begins]' I see the phases are the problem. DZPS is run first because it implements 'Dist::Zilla::Role::ShareDir', and the ShareDir phase is run before the FileMunger phase, which is what DZPST implements. On Tue Mar 05 19:38:36 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> On 13-03-05 07:16 PM, Nathan Gary Glenn via RT wrote:
> > This is actually a bug, not a wishlist or documentation problem.
DZPST Show quoted text
> > either needs to run before DZPS (which I would like better), or it
needs Show quoted text
> > to put the tarball back into the same directory.
> > The order in which plugins are running are dictated by the order
in Show quoted text
> which they appear in your dist.ini. So, in theory, you just have to
make Show quoted text
> sure that DZPS appears after DZPST, and everything should be good. > > Joy, > `/anick >
On Tue Mar 05 19:57:13 2013, NGLENN wrote: Show quoted text
> I see the phases are the problem. DZPS is run first because it > implements 'Dist::Zilla::Role::ShareDir', and the ShareDir phase is
run Show quoted text
> before the FileMunger phase, which is what DZPST implements. >
This works for me (replace lines 74-102): with 'Dist::Zilla::Role::ShareDir'; with 'Dist::Zilla::Role::FileInjector'; has dir => ( is => 'ro', isa => 'Str', default => 'share', ); sub find_files { my( $self ) = @_; print "Hello from tarballer!\n"; my $src = $self->dir; my @shared = grep { $_->name =~ m#^$src/# } @{ $self->zilla->files } or return; my $archive = Archive::Tar->new; for ( @shared ) { ( my $archive_name = $_->name ) =~ s#$src/##; $archive->add_data( $archive_name => $_->content ); $self->zilla->prune_file($_); } $self->add_file( Dist::Zilla::File::InMemory->new( name => 'share/shared-files.tar.gz', content => Compress::Zlib::memGzip($archive->write), ));} sub share_dir_map { my ($self) = @_; my $has_files = $self->find_files; return unless $has_files; return { dist => 'share' }; } With this, we no longer even need regular ol' [ShareDir]. I wonder if this is still backwards compatible with the old version though? It may require some people to reorder their own dist.ini's, since the 'Share Dir' phase happens sooner than the 'Munge Files' phase. I also don't know if losing the FileMunger role is a loss, since it does describe the module.
RT-Send-CC: garfieldnate [...] gmail.com, yanick [...] babyl.dyndns.org
Another option would be to path DZPS to allow a 'force' flag which adds the shared directory whether it finds files there or not. On Tue Mar 05 20:14:26 2013, NGLENN wrote: Show quoted text
> On Tue Mar 05 19:57:13 2013, NGLENN wrote: >
> > I see the phases are the problem. DZPS is run first because it > > implements 'Dist::Zilla::Role::ShareDir', and the ShareDir phase is
> run
> > before the FileMunger phase, which is what DZPST implements. > >
> > This works for me (replace lines 74-102): > > with 'Dist::Zilla::Role::ShareDir'; > with 'Dist::Zilla::Role::FileInjector'; > > has dir => ( > is => 'ro', > isa => 'Str', > default => 'share', > ); > > sub find_files { > my( $self ) = @_; > > print "Hello from tarballer!\n"; > my $src = $self->dir; > my @shared = grep { $_->name =~ m#^$src/# } @{ $self->zilla- >files > } > or return; > > my $archive = Archive::Tar->new; > > for ( @shared ) { > ( my $archive_name = $_->name ) =~ s#$src/##; > $archive->add_data( $archive_name => $_->content ); > $self->zilla->prune_file($_); > } > > $self->add_file( Dist::Zilla::File::InMemory->new( > name => 'share/shared-files.tar.gz', > content => Compress::Zlib::memGzip($archive->write), > ));} > > sub share_dir_map { > my ($self) = @_; > my $has_files = $self->find_files; > return unless $has_files; > > return { dist => 'share' }; > } > > With this, we no longer even need regular ol' [ShareDir]. I wonder if > this is still backwards compatible with the old version though? It may > require some people to reorder their own dist.ini's, since the 'Share > Dir' phase happens sooner than the 'Munge Files' phase. I also don't > know if losing the FileMunger role is a loss, since it does describe
the Show quoted text
> module.
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Thu, 07 Mar 2013 21:38:29 -0500
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
Okay, I think I got it. There's a new version on its way to CPAN where D:Z:P:SD:TB also consume the ShareDir role. Which means that indeed, we can do without D:Z:P:SD in the dist.ini config. Try it, and let me know if it works for you. :-) Joy, `/anick
RT-Send-CC: garfieldnate [...] gmail.com, yanick [...] babyl.dyndns.org
Works great! I appreciate the time you took to do this. On Thu Mar 07 21:38:49 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> Okay, I think I got it. There's a new version on its way to CPAN where > D:Z:P:SD:TB also consume the ShareDir role. Which means that indeed, we > can do without D:Z:P:SD in the dist.ini config. Try it, and let me know > if it works for you. :-) > > Joy, > `/anick
RT-Send-CC: garfieldnate [...] gmail.com, yanick [...] babyl.dyndns.org
Oops. Spoke too soon. I thought it had worked because I forgot to delete my old share files before running this. The behavior of this is still broken, though now different. No sharedir is installed. If we also use [Sharedir] with the dir option pointing to the original folder (not 'share', but value specified to the dir argument of [Shardir::Tarball]), then that will be stated as being the sharedir in Makefile and Build.PL. On Fri Mar 08 00:35:11 2013, NGLENN wrote: Show quoted text
> Works great! I appreciate the time you took to do this. > > On Thu Mar 07 21:38:49 2013, yanick@babyl.dyndns.org wrote:
> > Okay, I think I got it. There's a new version on its way to CPAN
where Show quoted text
> > D:Z:P:SD:TB also consume the ShareDir role. Which means that indeed,
we Show quoted text
> > can do without D:Z:P:SD in the dist.ini config. Try it, and let me
know Show quoted text
> > if it works for you. :-) > > > > Joy, > > `/anick
> >
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Sat, 09 Mar 2013 20:20:52 -0500
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 13-03-08 03:00 AM, Nathan Gary Glenn via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=83777 > > > Oops. Spoke too soon. I thought it had worked because I forgot to delete > my old share files before running this. > > The behavior of this is still broken, though now different. No sharedir > is installed. If we also use [Sharedir] with the dir option pointing to > the original folder (not 'share', but value specified to the dir > argument of [Shardir::Tarball]), then that will be stated as being the > sharedir in Makefile and Build.PL.
Can you create an example which display the problem? I've updated the GitHub repo (https://github.com/yanick/Dist-Zilla-Plugin-ShareDir-Tarball) with tests for both ::MakeMaker and ::ModuleBuild, and in both cases the (Makefile|Build).PL seems to be properly populated. It might be a question of what exactly resides in our respective dist.inis. Joy (and getting closer...), `/anick
RT-Send-CC: garfieldnate [...] gmail.com, yanick [...] babyl.dyndns.org
Alright, I narrowed it down and it may or may not be your problem (though it really may need documentation). I'm uploading an example. If [PodWeaver] is removed, or is used after [ShareDir::Tarball], then it works fine. Otherwise, no share directory is created. On Sat Mar 09 20:21:15 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> On 13-03-08 03:00 AM, Nathan Gary Glenn via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=83777 > > > > > Oops. Spoke too soon. I thought it had worked because I forgot to
delete Show quoted text
> > my old share files before running this. > > > > The behavior of this is still broken, though now different. No
sharedir Show quoted text
> > is installed. If we also use [Sharedir] with the dir option pointing
to Show quoted text
> > the original folder (not 'share', but value specified to the dir > > argument of [Shardir::Tarball]), then that will be stated as being
the Show quoted text
> > sharedir in Makefile and Build.PL.
> > Can you create an example which display the problem? I've
updated the Show quoted text
> GitHub repo > (https://github.com/yanick/Dist-Zilla-Plugin-ShareDir-Tarball) with > tests for both ::MakeMaker and ::ModuleBuild, and in both cases the > (Makefile|Build).PL seems to be properly populated. It might be a > question of what exactly resides in our respective dist.inis. > > Joy (and getting closer...), > `/anick >
Subject: Test-DZST.zip
Download Test-DZST.zip
application/octet-stream 2.6k

Message body not shown because it is not plain text.

CC: garfieldnate [...] gmail.com
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Sun, 10 Mar 2013 12:10:58 -0400
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 13-03-09 11:56 PM, Nathan Gary Glenn via RT wrote: Show quoted text
> Alright, I narrowed it down and it may or may not be your problem > (though it really may need documentation). I'm uploading an example.
Excellent. Mucho thanks, having a concrete example to poke at really makes things easier. Show quoted text
> If [PodWeaver] is removed, or is used after [ShareDir::Tarball], then it > works fine. Otherwise, no share directory is created.
Aaaand I think I know why it does what it does in this case. The shared abc/xyz directory only contains an empty file. Put something, anything, in that file, and *pop!*, your shared tarball is going to appear. `/.
Hmmm that didn't work for me. When I add printouts, it seem that the presence or absence of [PodWeaver] changes which phase DZPST is run in. The following works for me, though: package Dist::Zilla::Plugin::ShareDir::Tarball; BEGIN { $Dist::Zilla::Plugin::ShareDir::Tarball::AUTHORITY = 'cpan:YANICK'; } { $Dist::Zilla::Plugin::ShareDir::Tarball::VERSION = '0.3.1'; } # ABSTRACT: Bundle your shared dir into a tarball use strict; use warnings; use Moose; use Dist::Zilla::File::InMemory; use Compress::Zlib; use Archive::Tar; has dir => ( is => 'ro', isa => 'Str', default => 'share', ); has archive => ( is => 'ro', lazy => 1, predicate => 'has_archive', default => sub { Archive::Tar->new; }, ); has sharedir_checked => ( is => 'rw', lazy => 1, isa => 'Bool', default => 0, ); has shared_files => ( is => 'rw', lazy => 1, isa => 'ArrayRef[Dist::Zilla::File::OnDisk]', default => sub { [] }, ); has share_dir_map => ( is => 'ro', lazy => 1, default => sub { my $self = shift; print "checking for share dir!\n"; if(not $self->sharedir_checked){ $self->check_sharedir; } return {} unless @{$self->shared_files}; print "had a share dir!\n"; return { dist => $self->dir }; }, ); sub compressed_archive { Compress::Zlib::memGzip($_[0]->archive->write) } sub find_files { my $self = shift; my $dir = $self->dir . '/'; return grep { print 'index of ' . $_->name . ' in ' . "$dir is " . (!index $_->name, $dir) . "\n"; !index $_->name, $dir } @{ $self->zilla- Show quoted text
>files };
} sub check_sharedir { my $self = shift; my @shared = $self->find_files; # $self->sharedir_checked(1); $self->shared_files(\@shared); $self->sharedir_checked(1); } sub munge_files { my( $self ) = @_; $self->check_sharedir unless $self->sharedir_checked; my $src = $self->dir; my @shared = @{$self->shared_files} or return; for ( @shared ) { ( my $archive_name = $_->name ) =~ s#$src/##; $self->archive->add_data( $archive_name => $_->content ); $self->zilla->prune_file($_); } $self->add_file( Dist::Zilla::File::InMemory->new( name => 'share/shared-files.tar.gz', content => $self->compressed_archive, )); print "munge files got here\n"; } with 'Dist::Zilla::Role::ShareDir', 'Dist::Zilla::Role::FileInjector', 'Dist::Zilla::Role::FileMunger'; 1; I've never used Moose before, so maybe it could use a fixup. There's also a little bit of printing cruft I used for debugging. But basically it will check if files have been searched for yet, and if not it will search for them. It checks this at any phase (munge files or sharedir phases) and saves the search result so you don't have to search twice. On my machine, at least, it doesn't matter if the found files have contents or not; they just need to exist. On Sun Mar 10 12:11:19 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> On 13-03-09 11:56 PM, Nathan Gary Glenn via RT wrote:
> > Alright, I narrowed it down and it may or may not be your problem > > (though it really may need documentation). I'm uploading an example.
> > Excellent. Mucho thanks, having a concrete example to poke at
really Show quoted text
> makes things easier. >
> > If [PodWeaver] is removed, or is used after [ShareDir::Tarball],
then it Show quoted text
> > works fine. Otherwise, no share directory is created.
> > Aaaand I think I know why it does what it does in this case. The
shared Show quoted text
> abc/xyz directory only contains an empty file. Put something,
anything, Show quoted text
> in that file, and *pop!*, your shared tarball is going to appear. > > `/. > > >
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Mon, 11 Mar 2013 20:33:30 -0400
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
For giggles, what is the output of 'prove -l' for you? For me it's $ prove -l t/00-compile.t ................ ok t/000-report-versions-tiny.t .. # # # Generated by Dist::Zilla::Plugin::ReportVersions::Tiny v1.08 # perl: 5.016001 (wanted any version) on linux from /usr/local/soft/perlbrew/perls/perl-5.16.1/bin/perl # # Archive::Tar => 1.90 (want any version) # Compress::Zlib => 2.048 (want any version) # Dist::Zilla::File::InMemory => 4.300028 (want any version) # Dist::Zilla::Role::FileInjector => 4.300028 (want any version) # Dist::Zilla::Role::FileMunger => 4.300028 (want any version) # Dist::Zilla::Role::ShareDir => 4.300028 (want any version) # File::Find => 1.20 (want any version) # File::Temp => 0.22 (want any version) # Module::Build => 0.4003 (want 0.3601) # Moose => 2.0604 (want any version) # Test::DZil => 4.300028 (want any version) # Test::More => 0.98 (want 0.88) # strict => 1.07 (want any version) # version => 0.9901 (want 0.9901) # warnings => 1.13 (want any version) # # Thanks for using my code. I hope it works for you. # If not, please try and include this output in the bug report. # That will help me reproduce the issue and solve your problem. # t/000-report-versions-tiny.t .. ok t/basic.t ..................... ok All tests successful. Files=3, Tests=4, 7 wallclock secs ( 0.07 usr 0.00 sys + 2.78 cusr 0.21 csys = 3.06 CPU) Result: PASS
*giggle* t\00-compile.t ................ 1..1 ok 1 - Dist::Zilla::Plugin::ShareDir::Tarball loaded ok ok t\000-report-versions-tiny.t .. # # # Generated by Dist::Zilla::Plugin::ReportVersions::Tiny v1.08 # perl: 5.016001 (wanted any version) on MSWin32 from C:\strawberry\perl\bin\per l.exe # # Archive::Tar => 1.88 (want any version) # Compress::Zlib => 2.055 (want any version) # Dist::Zilla::File::InMemory => 4.300030 (want any version) # Dist::Zilla::Role::FileInjector => 4.300030 (want any version) # Dist::Zilla::Role::FileMunger => 4.300030 (want any version) # Dist::Zilla::Role::ShareDir => 4.300030 (want any version) # File::Find => 1.20 (want any version) # File::Temp => 0.22 (want any version) # Module::Build => 0.4002 (want 0.3601) # Moose => 2.0603 (want any version) # Test::DZil => 4.300030 (want any version) # Test::More => 0.98 (want 0.88) # strict => 1.07 (want any version) # version => 0.9901 (want 0.9901) # warnings => 1.13 (want any version) # # Thanks for using my code. I hope it works for you. # If not, please try and include this output in the bug report. # That will help me reproduce the issue and solve your problem. # ok 1 - we really didn't test anything, just reporting data 1..1 ok t\basic.t ..................... 1..2 1..6 ok 1 - there is only one file ok 2 - and it's the tarball ok 3 - foo present ok 4 - bar present ok 5 - Makefile.PL present ok 6 - Makefile.PL has the sharedir directive ok 1 - with corpus corpus 1..6 ok 1 - there is only one file ok 2 - and it's the tarball ok 3 - foo present ok 4 - bar present ok 5 - Makefile.PL present ok 6 - Makefile.PL has the sharedir directive ok 2 - with corpus corpus-dir ok All tests successful. Files=3, Tests=4, 19 wallclock secs ( 0.16 usr + 0.16 sys = 0.31 CPU) Result: PASS On Mon Mar 11 20:33:46 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> For giggles, what is the output of 'prove -l' for you? For me it's > > $ prove -l > t/00-compile.t ................ ok > t/000-report-versions-tiny.t .. # > # > # Generated by Dist::Zilla::Plugin::ReportVersions::Tiny v1.08 > # perl: 5.016001 (wanted any version) on linux from > /usr/local/soft/perlbrew/perls/perl-5.16.1/bin/perl > # > # Archive::Tar => 1.90 (want
any Show quoted text
> version) > # Compress::Zlib => 2.048 (want
any Show quoted text
> version) > # Dist::Zilla::File::InMemory => 4.300028 (want
any Show quoted text
> version) > # Dist::Zilla::Role::FileInjector => 4.300028 (want
any Show quoted text
> version) > # Dist::Zilla::Role::FileMunger => 4.300028 (want
any Show quoted text
> version) > # Dist::Zilla::Role::ShareDir => 4.300028 (want
any Show quoted text
> version) > # File::Find => 1.20 (want
any Show quoted text
> version) > # File::Temp => 0.22 (want
any Show quoted text
> version) > # Module::Build => 0.4003 (want
0.3601) Show quoted text
> # Moose => 2.0604 (want
any Show quoted text
> version) > # Test::DZil => 4.300028 (want
any Show quoted text
> version) > # Test::More => 0.98 (want
0.88) Show quoted text
> # strict => 1.07 (want
any Show quoted text
> version) > # version => 0.9901 (want
0.9901) Show quoted text
> # warnings => 1.13 (want
any Show quoted text
> version) > # > # Thanks for using my code. I hope it works for you. > # If not, please try and include this output in the bug report. > # That will help me reproduce the issue and solve your problem. > # > t/000-report-versions-tiny.t .. ok > t/basic.t ..................... ok > All tests successful. > Files=3, Tests=4, 7 wallclock secs ( 0.07 usr 0.00 sys + 2.78 cusr > 0.21 csys = 3.06 CPU) > Result: PASS
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Mon, 11 Mar 2013 21:28:05 -0400
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
Oh ye gods, I'm a poodle-brain. The shared tarball was always plunked in 'share', but the hash_map returned to the main dzil object could be based on $self->dir (which in the case of the example is 'abc/xyz'). New patched version at https://github.com/yanick/Dist-Zilla-Plugin-ShareDir-Tarball, including your specific example as one of the tests. Mind trying out that one? Might be the last iteration you have to go through. :-) Joy, `/anick
Would you mind posting a build? I can't do 'dzil build' because WWW- Shorten fails on Windows, and I don't know exactly what part of the @Yanick INI setting creates that dependency. I did apply the small changes to Tarball.pm, and they work on the example distro I gave you. It didn't work on my actual distro, however. Heh. I'm posting another minimal failing example (fails with the newest version of Tarball.pm). On Mon Mar 11 21:28:23 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> > Oh ye gods, I'm a poodle-brain. > > The shared tarball was always plunked in 'share', but the
hash_map Show quoted text
> returned to the main dzil object could be based on $self->dir (which
in Show quoted text
> the case of the example is 'abc/xyz'). > > New patched version at > https://github.com/yanick/Dist-Zilla-Plugin-ShareDir-Tarball,
including Show quoted text
> your specific example as one of the tests. Mind trying out that one? > Might be the last iteration you have to go through. :-) > > Joy, > `/anick
Subject: Test-DZST-2.zip
Download Test-DZST-2.zip
application/octet-stream 2.7k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Tue, 12 Mar 2013 20:09:17 -0400
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 13-03-12 02:03 AM, Nathan Gary Glenn via RT wrote: Show quoted text
> Would you mind posting a build?
Oh. Right. Here we go: https://github.com/yanick/Dist-Zilla-Plugin-ShareDir-Tarball/tree/build/master And it has new changes to address the stuff below --v Show quoted text
> I did apply the small > changes to Tarball.pm, and they work on the example distro I gave you.
WOOHOO!! Show quoted text
> It didn't work on my actual distro, however.
AUGH!!! Show quoted text
> Heh. I'm posting another > minimal failing example (fails with the newest version of Tarball.pm).
If nothing else, we're building a killer collection of test cases. ;-) I've made that example work. Up to now, DZPSDT was doing its magic in the MungeFiles phase of the build. I'm beginning to suspect that this is wrong -- MungeFiles expects you to do things to files, but not to pop in new ones. Soooo I moved the operations in the earlier GatherFiles stage. And it seems to do the trick. Would you be so kind as to checkout the build branch, and see if the module will finally have the good grace to behave? :-) Aaaaalmost there, `/anick
Great! It works! I did have to force the install, though, since the tests went kablooie (it fails with an error I saw a whole bunch while trying to edit the distro). I'm posting the log. On Tue Mar 12 20:09:34 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> On 13-03-12 02:03 AM, Nathan Gary Glenn via RT wrote:
> > Would you mind posting a build?
> > Oh. Right. Here we go: > https://github.com/yanick/Dist-Zilla-Plugin-ShareDir- > Tarball/tree/build/master > > And it has new changes to address the stuff below --v > >
> > I did apply the small > > changes to Tarball.pm, and they work on the example distro I gave
> you. > > WOOHOO!! >
> > It didn't work on my actual distro, however.
> > AUGH!!! >
> > Heh. I'm posting another > > minimal failing example (fails with the newest version of
> Tarball.pm). > > If nothing else, we're building a killer collection of test
cases. ;- Show quoted text
> ) > > I've made that example work. Up to now, DZPSDT was doing its
magic in Show quoted text
> the MungeFiles phase of the build. I'm beginning to suspect that this > is > wrong -- MungeFiles expects you to do things to files, but not to pop > in > new ones. Soooo I moved the operations in the earlier GatherFiles > stage. > And it seems to do the trick. Would you be so kind as to checkout the > build branch, and see if the module will finally have the good grace > to > behave? :-) > > Aaaaalmost there, > `/anick >
Subject: build.log
Download build.log
application/octet-stream 11.2k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Tue, 12 Mar 2013 20:38:06 -0400
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 13-03-12 08:25 PM, Nathan Gary Glenn via RT wrote: Show quoted text
> Great! It works!
Music to my ears. ^.^ Show quoted text
> I did have to force the install, though, since the > tests went kablooie (it fails with an error I saw a whole bunch while > trying to edit the distro). I'm posting the log.
That's all okay... just clean-up I have to do. I'll do that, anonymize your examples a wee bit, and I'll punt off a release sometime this week. Thanks for your help! Joy, `/anick
Thank you! I feel like I made you rewrite the whole thing. This will all be very useful, though! On Tue Mar 12 20:38:25 2013, yanick@babyl.dyndns.org wrote: Show quoted text
> On 13-03-12 08:25 PM, Nathan Gary Glenn via RT wrote:
> > Great! It works!
> > Music to my ears. ^.^ >
> > I did have to force the install, though, since the
> > tests went kablooie (it fails with an error I saw a whole bunch
while Show quoted text
> > trying to edit the distro). I'm posting the log.
> > That's all okay... just clean-up I have to do. I'll do that,
anonymize Show quoted text
> your examples a wee bit, and I'll punt off a release sometime this
week. Show quoted text
> Thanks for your help! > > Joy, > `/anick >
Subject: Re: [rt.cpan.org #83777] documentation/option on tarball output location
Date: Thu, 14 Mar 2013 20:03:01 -0400
To: bug-Dist-Zilla-Plugin-ShareDir-Tarball [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 13-03-12 09:29 PM, Nathan Gary Glenn via RT wrote: Show quoted text
> Thank you! I feel like I made you rewrite the whole thing.
You made me improve it, and a few dzil gotchas in the process, which are both good things. :-) Show quoted text
>This will all be very useful, though!
Excellent. That, right there, is all that is needed to make it worth it. :-) Enjoy! `/anick