Bug #83710 for DBIx-Class: `make distdir` does not work on win32

Fri Mar 01 10:53:42 2013 MITHALDU [...] cpan.org - Ticket created

Subject:

`make distdir` does not work on win32

Trying to run `make distdir` on win32 with dmake results in instances of $E and $_ in the makefile being interpolated to '.exe' and '' respectively. In the branch 'win32_distdir' is a commit that fixes those instances. I tested the relevant code on both win32 and a debian box.

Fri Mar 01 11:23:43 2013 ribasushi [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Sat, 2 Mar 2013 03:23:35 +1100
To:	Christian Walde via RT <bug-DBIx-Class [...] rt.cpan.org>
From:	Peter Rabbitson <ribasushi [...] cpan.org>

On Fri, Mar 01, 2013 at 10:53:44AM -0500, Christian Walde via RT wrote: Show quoted text

> Fri Mar 01 10:53:42 2013: Request 83710 was acted upon. > Transaction: Ticket created by MITHALDU > Queue: DBIx-Class > Subject: `make distdir` does not work on win32 > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: MITHALDU@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83710 > > > > Trying to run `make distdir` on win32 with dmake results in instances of > $E and $_ in the makefile being interpolated to '.exe' and '' > respectively. In the branch 'win32_distdir' is a commit that fixes those > instances. > > I tested the relevant code on both win32 and a debian box.

This issue has come up in the past - it is actually a weird problem with corruption of the EUMM bundlerd with your perl due to some weird downgrade. I.e. your branch as written fails on my debian system, also on a cygwin and a strawbery 5.16 I have access to. If you rebase your branch on current master (so that you grab this commit [1]) you will see that travis is failing as well. This needs more investigation. Please give me the versions of your perl (perl -V) and the version of your ExtUtils::MakeMaker Cheers [1] https://github.com/dbsrgits/dbix-class/commit/a0acdea0

Fri Mar 01 11:23:47 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 01 12:18:05 2013 walde.christian [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Fri, 01 Mar 2013 18:17:54 +0100
To:	"Peter Rabbitson via RT" <bug-DBIx-Class [...] rt.cpan.org>
From:	"Christian Walde" <walde.christian [...] gmail.com>

Thanks for the hint with EUMM, you were right, kinda. I didn't have a weird eumm, since mine was from CPAN, i did have an old one though, 6.62. I went through it with frew in tmux to find that out. After upgrading my EUMM to 6.64, `perl Makefile.PL && dmake distdir` works like a charm. As such i've amended my commit and forcepushed to win32_distdir, a commit that sets the build dependency on EUMM to 6.64. Please take a look at it and merge/rebase it if you think it's ok. :) -- With regards, Christian Walde

Fri Mar 01 12:41:54 2013 ribasushi [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Sat, 2 Mar 2013 04:41:45 +1100
To:	Christian Walde via RT <bug-DBIx-Class [...] rt.cpan.org>
From:	Peter Rabbitson <ribasushi [...] cpan.org>

On Fri, Mar 01, 2013 at 12:18:06PM -0500, Christian Walde via RT wrote: Show quoted text

> Queue: DBIx-Class > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83710 > > > Thanks for the hint with EUMM, you were right, kinda. I didn't have a > weird eumm, since mine was from CPAN, i did have an old one though, 6.62. > I went through it with frew in tmux to find that out. > > After upgrading my EUMM to 6.64, `perl Makefile.PL && dmake distdir` works > like a charm. > > As such i've amended my commit and forcepushed to win32_distdir, a commit > that sets the build dependency on EUMM to 6.64. > > Please take a look at it and merge/rebase it if you think it's ok. :)

This problem manifests itself only in author mode. As such having a non-trivial dep imposed on all users seems excessive. I will rewrite this in terms of optdeps a tad later today, though I am still not sure this is the core of the issue.

Fri Mar 01 13:16:11 2013 walde.christian [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Fri, 01 Mar 2013 19:16:00 +0100
To:	MITHALDU [...] cpan.org, "Peter Rabbitson via RT" <bug-DBIx-Class [...] rt.cpan.org>
From:	"Christian Walde" <walde.christian [...] gmail.com>

On Fri, 01 Mar 2013 18:41:55 +0100, Peter Rabbitson via RT <bug-DBIx-Class@rt.cpan.org> wrote: Show quoted text

> This problem manifests itself only in author mode. As such having a > non-trivial dep imposed on all users seems excessive. I will rewrite > this in terms of optdeps a tad later today,

That makes perfect sense, yes. Show quoted text

> though I am still not sure this is the core of the issue.

Trust me on this one, it is. Three people looked at the matter and agreed. :) -- With regards, Christian Walde

Sat Mar 02 02:38:31 2013 ribasushi [...] leporine.io - Correspondence added

On Fri Mar 01 13:16:11 2013, walde.christian@gmail.com wrote: Show quoted text

> On Fri, 01 Mar 2013 18:41:55 +0100, Peter Rabbitson via RT > <bug-DBIx-Class@rt.cpan.org> wrote: >

> > This problem manifests itself only in author mode. As such having a > > non-trivial dep imposed on all users seems excessive. I will rewrite > > this in terms of optdeps a tad later today,

> > That makes perfect sense, yes. >

Ypur change was applied as such: https://github.com/dbsrgits/dbix-class/commit/844328269f5d Before it is merged please try the smoke/dist branch, verify it works for you as expected (already verfied locally and on travis). Show quoted text

> Trust me on this one, it is. Three people looked at the matter and

agreed. Trust me it is not - there is some very subtle bug with EUMM downgrading itself on 5.16 when someone asks for `cpanm ExtUtils::MakeMaker` I ran out of tuits to diagnose it, but it is not something that is "fixed" in 6.64 - the upgrade to 6.64 merely masks the issue away.

Sat Mar 02 02:38:34 2013 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'

Sat Mar 02 07:04:21 2013 walde.christian [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Sat, 02 Mar 2013 13:04:03 +0100
To:	"Peter Rabbitson via RT" <bug-DBIx-Class [...] rt.cpan.org>
From:	"Christian Walde" <walde.christian [...] gmail.com>

On Sat, 02 Mar 2013 08:38:34 +0100, Peter Rabbitson via RT <bug-DBIx-Class@rt.cpan.org> wrote: Show quoted text

> Ypur change was applied as such: > https://github.com/dbsrgits/dbix-class/commit/844328269f5d Before it is > merged please try the smoke/dist branch, verify it works for you as > expected (already verfied locally and on travis).

Will do in a few hours. Show quoted text

> there is some very subtle bug with EUMM downgrading > itself on 5.16 when someone asks for `cpanm ExtUtils::MakeMaker`

Actually, i know that. It is a very unsubtle bug really. This was released in November 2012: https://metacpan.org/release/RJBS/perl-5.16.2/ It contains EUMM 6.63_02: https://metacpan.org/source/RJBS/perl-5.16.2/cpan/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm#L21 EUMM 6.64 was released in December 2012: https://metacpan.org/release/MSCHWERN/ExtUtils-MakeMaker-6.64/ cpanm will use the PAUSE index files to determine the highest version of a module dependency, which does not include dev releases. So the bug was twofold: cpanm didn't verify whether its actions would downgrade or not. perl core was released with a dev version of EUMM newer than anything on cpan. Requiring EUMM 6.64 for DBIC does not mask anything, it is the correct thing to do. The faulty core release has been fixed by a release of 6.64 to CPAN. The only thing remaining that might merit looking into is cpanm's install behavior, to add checks preventing downgrades. And with the recent release of cpanm that might actually have already been fixed as well, so you might want to ask miyagawa. -- With regards, Christian Walde

Sat Mar 02 07:04:28 2013 The RT System itself - Status changed from 'patched' to 'open'

Sat Mar 02 07:52:56 2013 ribasushi [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Sat, 2 Mar 2013 23:52:43 +1100
To:	Christian Walde via RT <bug-DBIx-Class [...] rt.cpan.org>
From:	Peter Rabbitson <ribasushi [...] cpan.org>

On Sat, Mar 02, 2013 at 07:04:25AM -0500, Christian Walde via RT wrote: Show quoted text

> Queue: DBIx-Class > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83710 > > > On Sat, 02 Mar 2013 08:38:34 +0100, Peter Rabbitson via RT > <bug-DBIx-Class@rt.cpan.org> wrote: >

> > Ypur change was applied as such: > > https://github.com/dbsrgits/dbix-class/commit/844328269f5d Before it is > > merged please try the smoke/dist branch, verify it works for you as > > expected (already verfied locally and on travis).

> > Will do in a few hours.

Excellent, let me know. Show quoted text

> > there is some very subtle bug with EUMM downgrading > > itself on 5.16 when someone asks for `cpanm ExtUtils::MakeMaker`

> > Actually, i know that. It is a very unsubtle bug really.

I should have used more words - the subtle part is that a *downgrade* breaks things in such a weird way. That generally should not be happening given that EU::MM is monolithic. But anyway - the depbump solves it, so good enough.

Sat Mar 02 10:38:58 2013 walde.christian [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Sat, 02 Mar 2013 16:38:44 +0100
To:	"Peter Rabbitson via RT" <bug-DBIx-Class [...] rt.cpan.org>
From:	"Christian Walde" <walde.christian [...] gmail.com>

On Sat, 02 Mar 2013 13:52:58 +0100, Peter Rabbitson via RT <bug-DBIx-Class@rt.cpan.org> wrote: Show quoted text

>>> Ypur change was applied as such: >>> https://github.com/dbsrgits/dbix-class/commit/844328269f5d Before it is >>> merged please try the smoke/dist branch, verify it works for you as >>> expected (already verfied locally and on travis).

>> >> Will do in a few hours.

> > Excellent, let me know.

Tested it on my debian box and it does the right thing. Nothing during Makefile.PL and an explicit complaint when i ran make distdir. Show quoted text

>>> there is some very subtle bug with EUMM downgrading >>> itself on 5.16 when someone asks for `cpanm ExtUtils::MakeMaker`

>> >> Actually, i know that. It is a very unsubtle bug really.

> > I should have used more words - the subtle part is that a *downgrade* > breaks things in such a weird way. That generally should not be > happening given that EU::MM is monolithic. But anyway - the depbump > solves it, so good enough.

Ah. I can see how that could be an issue on some systems. I can also give you a guarantee that it did not happen on my debian box, since that doesn't even have cpanm. ;) -- With regards, Christian Walde

Sat Mar 02 10:45:28 2013 ribasushi [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #83710] `make distdir` does not work on win32
Date:	Sun, 3 Mar 2013 02:45:14 +1100
To:	Christian Walde via RT <bug-DBIx-Class [...] rt.cpan.org>
From:	Peter Rabbitson <ribasushi [...] cpan.org>

On Sat, Mar 02, 2013 at 10:39:01AM -0500, Christian Walde via RT wrote: Show quoted text

> Queue: DBIx-Class > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83710 > > > On Sat, 02 Mar 2013 13:52:58 +0100, Peter Rabbitson via RT > <bug-DBIx-Class@rt.cpan.org> wrote: >

> >>> Ypur change was applied as such: > >>> https://github.com/dbsrgits/dbix-class/commit/844328269f5d Before it is > >>> merged please try the smoke/dist branch, verify it works for you as > >>> expected (already verfied locally and on travis).

> >> > >> Will do in a few hours.

> > > > Excellent, let me know.

> > Tested it on my debian box and it does the right thing. Nothing during > Makefile.PL and an explicit complaint when i ran make distdir. >

Excellent, pushed. Show quoted text

> >>> there is some very subtle bug with EUMM downgrading > >>> itself on 5.16 when someone asks for `cpanm ExtUtils::MakeMaker`

> >> > >> Actually, i know that. It is a very unsubtle bug really.

> > > > I should have used more words - the subtle part is that a *downgrade* > > breaks things in such a weird way. That generally should not be > > happening given that EU::MM is monolithic. But anyway - the depbump > > solves it, so good enough.

> > Ah. I can see how that could be an issue on some systems. I can also give > you a guarantee that it did not happen on my debian box, since that > doesn't even have cpanm. ;) >

I misspoke again - I wasn't singling out 'cpanm' as the culprit, I meant to give an example of a module install is all. I sadly ran out of tuits to look into this any further, so closing it in my mind ;) Cheers and thanks for testing!

Sat Mar 02 10:48:22 2013 ribasushi [...] leporine.io - Correspondence added

https://github.com/dbsrgits/dbix-class/commit/b81d8515#diff-1

Sat Mar 02 10:48:23 2013 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'