Bug #83534 for Convert-Age: Input checking for decode

Fri Feb 22 10:21:41 2013 NORMUNDS [...] cpan.org - Ticket created

Subject:

Input checking for decode_age()

Hi, I need functionality provided by Convert::Age, but I need strict input checking and error reporting. Currently Convert::Age 0.04 doesn't check for unexistant abbreviations given as arguments so I wrote a patch with following changes: * Strict input checking * Human-Readable error string accessible with error() function. * Added Weeks and Months de/encoding capability. * Added tests for decode_age_strict * Updated documentation * Updated original tests to be able to test weeks. * Updated MANIFEST - added tests. * Updated Changelog * Updated version. The reason why new function was made is for backward compatibility You can apply patch and release new version or alternatively I could become co-maintainer or maintainer of this package and do this myself (and also update the package if needed). Please ask if you have any questions. Thanks and best regards, Normunds Neimanis

Subject:

CA.patch

Message body is not shown because it is too large.

Fri Feb 22 22:03:27 2013 chris [...] fedde.us - Correspondence added

Subject:	Re: [rt.cpan.org #83534] Input checking for decode_age()
Date:	Fri, 22 Feb 2013 20:03:13 -0700
To:	bug-Convert-Age [...] rt.cpan.org
From:	Chris Fedde <chris [...] fedde.us>

On Fri, Feb 22, 2013 at 8:21 AM, Normunds Neimanis via RT < bug-Convert-Age@rt.cpan.org> wrote: Show quoted text

> Fri Feb 22 10:21:41 2013: Request 83534 was acted upon. > Transaction: Ticket created by NORMUNDS > Queue: Convert-Age > Subject: Input checking for decode_age() > Broken in: 0.04 > Severity: Wishlist > Owner: Nobody > Requestors: NORMUNDS@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=83534 > > > > Hi, > I need functionality provided by Convert::Age, but I need strict input > checking and error reporting. Currently Convert::Age 0.04 doesn't check > for unexistant abbreviations given as arguments so I wrote a patch with > following changes: > * Strict input checking > * Human-Readable error string accessible with error() function. > * Added Weeks and Months de/encoding capability. > * Added tests for decode_age_strict > * Updated documentation > * Updated original tests to be able to test weeks. > * Updated MANIFEST - added tests. > * Updated Changelog > * Updated version. > > The reason why new function was made is for backward compatibility > > You can apply patch and release new version or alternatively I could > become co-maintainer or maintainer of this package and do this myself > (and also update the package if needed). > > Please ask if you have any questions. > > Thanks and best regards, > Normunds Neimanis >

Fri Feb 22 22:03:27 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 17 21:57:10 2013 chris [...] fedde.us - Correspondence added

NORMUNDS Sorry for the delay. Please thank MST for grabbing me by the tail and getting me to look at this. I see no reason why it cannot be incorporated into the module. Updates soon. chris On Fri Feb 22 10:21:41 2013, NORMUNDS wrote: Show quoted text

> Hi, > I need functionality provided by Convert::Age, but I need strict input > checking and error reporting. Currently Convert::Age 0.04 doesn't check > for unexistant abbreviations given as arguments so I wrote a patch with > following changes: > * Strict input checking > * Human-Readable error string accessible with error() function. > * Added Weeks and Months de/encoding capability. > * Added tests for decode_age_strict > * Updated documentation > * Updated original tests to be able to test weeks. > * Updated MANIFEST - added tests. > * Updated Changelog > * Updated version. > > The reason why new function was made is for backward compatibility > > You can apply patch and release new version or alternatively I could > become co-maintainer or maintainer of this package and do this myself > (and also update the package if needed). > > Please ask if you have any questions. > > Thanks and best regards, > Normunds Neimanis

Mon Jun 17 23:10:30 2013 chris [...] fedde.us - Correspondence added

On review of this patch it seems to attempt to alter t/01-check.t in a way that is not compatible with the previous tests. I've created a git repo for this module: https://github.com/cfedde/Convert-Age https://github.com/cfedde/Convert-Age.git It would be awesome if you could check this out and merge and prove your changes there. Feel free to provide a git diff or a pull request. I could also give you a commit bit if you'd rather. Of course another plausibility is to simply cast your module as a totally new distribution say Convert::Age::Strict or something. Feel free to steal my code if you choose to take that approach. Let me know how you would like to proceed. I'll try to take less time responding next time. On Mon Jun 17 21:57:10 2013, CFEDDE wrote: Show quoted text

> NORMUNDS > > Sorry for the delay. Please thank MST for grabbing me by the tail and > getting me to look at this. I see no reason why it cannot be > incorporated into the module. > > Updates soon. > chris > > On Fri Feb 22 10:21:41 2013, NORMUNDS wrote:

> > Hi, > > I need functionality provided by Convert::Age, but I need strict

> input

> > checking and error reporting. Currently Convert::Age 0.04 doesn't

> check

> > for unexistant abbreviations given as arguments so I wrote a patch

> with

> > following changes: > > * Strict input checking > > * Human-Readable error string accessible with error() function. > > * Added Weeks and Months de/encoding capability. > > * Added tests for decode_age_strict > > * Updated documentation > > * Updated original tests to be able to test weeks. > > * Updated MANIFEST - added tests. > > * Updated Changelog > > * Updated version. > > > > The reason why new function was made is for backward compatibility > > > > You can apply patch and release new version or alternatively I could > > become co-maintainer or maintainer of this package and do this

> myself

> > (and also update the package if needed). > > > > Please ask if you have any questions. > > > > Thanks and best regards, > > Normunds Neimanis

Tue Jun 18 02:49:37 2013 long [...] rule.lv - Correspondence added

Subject:	Re: [rt.cpan.org #83534] Input checking for decode_age()
Date:	Tue, 18 Jun 2013 09:49:18 +0300 (EEST)
To:	bug-Convert-Age [...] rt.cpan.org
From:	"Normunds Neimanis" <long [...] rule.lv>

Hi, Github looks like the best option for me. And incorporating changes in Convert::Age also is better because then I don't have to make new package for Fedora where I'm using this module. I'll make pull request when changes are ready. Show quoted text

> On review of this patch it seems to attempt to alter t/01-check.t in a way > that is not compatible with the previous tests.

I'll also look at this. Best regards, Normunds Neimanis Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=83534 > > > On review of this patch it seems to attempt to alter t/01-check.t in a way > that is not compatible with the previous tests. > > I've created a git repo for this module: > https://github.com/cfedde/Convert-Age > https://github.com/cfedde/Convert-Age.git > > It would be awesome if you could check this out and merge and prove your > changes there. Feel free to provide a git diff or a pull request. I > could also give you a commit bit if you'd rather. > > Of course another plausibility is to simply cast your module as a totally > new distribution say Convert::Age::Strict or something. > Feel free to steal my code if you choose to take that approach. > > Let me know how you would like to proceed. I'll try to take less time > responding next time. > > > On Mon Jun 17 21:57:10 2013, CFEDDE wrote:

>> NORMUNDS >> >> Sorry for the delay. Please thank MST for grabbing me by the tail and >> getting me to look at this. I see no reason why it cannot be >> incorporated into the module. >> >> Updates soon. >> chris >> >> On Fri Feb 22 10:21:41 2013, NORMUNDS wrote:

>> > Hi, >> > I need functionality provided by Convert::Age, but I need strict

>> input

>> > checking and error reporting. Currently Convert::Age 0.04 doesn't

>> check

>> > for unexistant abbreviations given as arguments so I wrote a patch

>> with

>> > following changes: >> > * Strict input checking >> > * Human-Readable error string accessible with error() function. >> > * Added Weeks and Months de/encoding capability. >> > * Added tests for decode_age_strict >> > * Updated documentation >> > * Updated original tests to be able to test weeks. >> > * Updated MANIFEST - added tests. >> > * Updated Changelog >> > * Updated version. >> > >> > The reason why new function was made is for backward compatibility >> > >> > You can apply patch and release new version or alternatively I could >> > become co-maintainer or maintainer of this package and do this

>> myself

>> > (and also update the package if needed). >> > >> > Please ask if you have any questions. >> > >> > Thanks and best regards, >> > Normunds Neimanis

> > > >

Tue Jun 18 03:17:41 2013 long [...] rule.lv - Correspondence added

Subject:	Re: [rt.cpan.org #83534] Input checking for decode_age()
Date:	Tue, 18 Jun 2013 10:17:27 +0300 (EEST)
To:	bug-Convert-Age [...] rt.cpan.org
From:	"Normunds Neimanis" <long [...] rule.lv>

I looked at 01-check.t and remembered that this test is changed because week abbreviation (w) is introduced and script converts 7 days (7d) to 1 week (1w) because it is more convenient to see small numbers. Unfortunately backwards compatibility is broken in this case. I could change script that it converts numbers in old way (7d instead of 1w, 24 hours instead of 1d etc), but it looks counter-intuitive. What do you think, how can we proceed with this? Best regards, Normunds Neimanis Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=83534 > > > Hi, > Github looks like the best option for me. And incorporating changes in > Convert::Age also is better because then I don't have to make new package > for Fedora where I'm using this module. > > I'll make pull request when changes are ready. >

>> On review of this patch it seems to attempt to alter t/01-check.t in a >> way >> that is not compatible with the previous tests.

> I'll also look at this. > > Best regards, > Normunds Neimanis >

>> <URL: https://rt.cpan.org/Ticket/Display.html?id=83534 > >> >> On review of this patch it seems to attempt to alter t/01-check.t in a >> way >> that is not compatible with the previous tests. >> >> I've created a git repo for this module: >> https://github.com/cfedde/Convert-Age >> https://github.com/cfedde/Convert-Age.git >> >> It would be awesome if you could check this out and merge and prove your >> changes there. Feel free to provide a git diff or a pull request. I >> could also give you a commit bit if you'd rather. >> >> Of course another plausibility is to simply cast your module as a >> totally >> new distribution say Convert::Age::Strict or something. >> Feel free to steal my code if you choose to take that approach. >> >> Let me know how you would like to proceed. I'll try to take less time >> responding next time. >> >> >> On Mon Jun 17 21:57:10 2013, CFEDDE wrote:

>>> NORMUNDS >>> >>> Sorry for the delay. Please thank MST for grabbing me by the tail and >>> getting me to look at this. I see no reason why it cannot be >>> incorporated into the module. >>> >>> Updates soon. >>> chris >>> >>> On Fri Feb 22 10:21:41 2013, NORMUNDS wrote:

>>> > Hi, >>> > I need functionality provided by Convert::Age, but I need strict

>>> input

>>> > checking and error reporting. Currently Convert::Age 0.04 doesn't

>>> check

>>> > for unexistant abbreviations given as arguments so I wrote a patch

>>> with

>>> > following changes: >>> > * Strict input checking >>> > * Human-Readable error string accessible with error() function. >>> > * Added Weeks and Months de/encoding capability. >>> > * Added tests for decode_age_strict >>> > * Updated documentation >>> > * Updated original tests to be able to test weeks. >>> > * Updated MANIFEST - added tests. >>> > * Updated Changelog >>> > * Updated version. >>> > >>> > The reason why new function was made is for backward compatibility >>> > >>> > You can apply patch and release new version or alternatively I could >>> > become co-maintainer or maintainer of this package and do this

>>> myself

>>> > (and also update the package if needed). >>> > >>> > Please ask if you have any questions. >>> > >>> > Thanks and best regards, >>> > Normunds Neimanis

>>>

>> >> >> >>

> > > > >

Tue Jun 18 11:25:28 2013 chris [...] fedde.us - Correspondence added

On Tue Jun 18 03:17:41 2013, long@rule.lv wrote: Show quoted text

> I looked at 01-check.t and remembered that this test is changed because > week abbreviation (w) is introduced and script converts 7 days (7d) to 1 > week (1w) because it is more convenient to see small numbers. > Unfortunately backwards compatibility is broken in this case. > > I could change script that it converts numbers in old way (7d instead of > 1w, 24 hours instead of 1d etc), but it looks counter-intuitive. > > What do you think, how can we proceed with this? > > > Best regards, > Normunds Neimanis >

I'll take a look at your changes when you have them. what is your github id? I'll give you commit bit on the module. I expect we can come up with a design that meets both our goals.

Tue Jun 18 12:19:39 2013 long [...] rule.lv - Correspondence added

Subject:	Re: [rt.cpan.org #83534] Input checking for decode_age()
Date:	Tue, 18 Jun 2013 19:19:18 +0300 (EEST)
To:	bug-Convert-Age [...] rt.cpan.org
From:	"Normunds Neimanis" <long [...] rule.lv>

I've applied and committed my patch. My github username is "Laucenieks". Best regards, Normunds Neimanis Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=83534 > > > On Tue Jun 18 03:17:41 2013, long@rule.lv wrote:

>> I looked at 01-check.t and remembered that this test is changed because >> week abbreviation (w) is introduced and script converts 7 days (7d) to 1 >> week (1w) because it is more convenient to see small numbers. >> Unfortunately backwards compatibility is broken in this case. >> >> I could change script that it converts numbers in old way (7d instead of >> 1w, 24 hours instead of 1d etc), but it looks counter-intuitive. >> >> What do you think, how can we proceed with this? >> >> >> Best regards, >> Normunds Neimanis >>

> > I'll take a look at your changes when you have them. what is your github > id? I'll give you commit bit on the module. I expect we can come up with > a design that meets both our goals. > >

Tue Jun 18 15:48:09 2013 chris [...] fedde.us - Correspondence added

On Tue Jun 18 12:19:39 2013, long@rule.lv wrote: Show quoted text

> I've applied and committed my patch. My github username is "Laucenieks". > > Best regards, > Normunds Neimanis

I think that you have commit for this repo now. Give a 'git push -u origin master' a try and let me know what goes wrong.

Wed Jun 19 10:45:20 2013 chris [...] fedde.us - Taken

Mon Dec 23 17:20:01 2013 chris [...] fedde.us - Correspondence added

On Tue Jun 18 15:48:09 2013, CFEDDE wrote: Show quoted text

> On Tue Jun 18 12:19:39 2013, long@rule.lv wrote:

> > I've applied and committed my patch. My github username is > > "Laucenieks". > > > > Best regards, > > Normunds Neimanis

> > I think that you have commit for this repo now. Give a 'git push -u > origin master' a try and let me know what goes wrong.

Did we want this ticket to remain open? I'm happy to relinquish control of this module to you if you want it. I'm no loger responsible for any code that makes use of it. thanks chris

Tue Dec 24 07:41:14 2013 long [...] rule.lv - Correspondence added

CC:	normunds [...] cpan.org
Subject:	Re: [rt.cpan.org #83534] Input checking for decode_age()
Date:	Tue, 24 Dec 2013 14:40:58 +0200 (EET)
To:	bug-Convert-Age [...] rt.cpan.org
From:	"Normunds Neimanis" <long [...] rule.lv>

Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=83534 > > > On Tue Jun 18 15:48:09 2013, CFEDDE wrote:

>> On Tue Jun 18 12:19:39 2013, long@rule.lv wrote:

>> > I've applied and committed my patch. My github username is >> > "Laucenieks". >> > >> > Best regards, >> > Normunds Neimanis

>> >> I think that you have commit for this repo now. Give a 'git push -u >> origin master' a try and let me know what goes wrong.

> > Did we want this ticket to remain open? I'm happy to relinquish control > of this module to you if you want it. I'm no loger responsible for any > code that makes use of it. > > thanks > chris > >

Hi, Unfortunately to Perl, my life situation has changed and I have less disposable time now, but this module still is in my to-do list, so I am about to make changes to it some day. The best for me would be to become co-maintainer of this module, if it's ok to you. Merry Christmas, Normunds Neimanis

Bug #83534 for Convert-Age: Input checking for decode_age()