Bug #83513 for DBIx-NinjaORM: Incorrect croak when verbose only

Thu Feb 21 15:55:13 2013 kolibrie [...] graystudios.org - Ticket created

On line 1468, there is a croak that should probably be a carp, so that behavior does not change when in verbose mode: croak "The field '$field' cannot be set and will be ignored" if $self->is_verbose();

Fri Feb 22 00:17:07 2013 AUBERTG [...] cpan.org - Subject changed from (no value) to 'Incorrect croak when verbose only'

Fri Feb 22 00:24:46 2013 AUBERTG [...] cpan.org - Correspondence added

On Thu Feb 21 15:55:13 2013, KOLIBRIE wrote: Show quoted text

> On line 1468, there is a croak that should probably be a carp, so that > behavior does not change when in verbose mode: > > croak "The field '$field' cannot be set and will be ignored" > if $self->is_verbose();

Excellent catch, thank you! I fixed it on GitHub (https://github.com/guillaumeaubert/DBIx-NinjaORM/commit/4f3b868b6a907c1226d0ee96884db63f32255ad5). I thought further about it and decided to use a warning passed to Log::Any independently of the verbose mode, since it is a problem in the calling code that the programmer should be notified about even if NinjaORM handles it gracefully. Please let me know if you have any questions, and I will try to do a release shortly with a couple of other bug fixes.

Fri Feb 22 00:24:46 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Feb 22 00:24:46 2013 AUBERTG [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #83513 for DBIx-NinjaORM: Incorrect croak when verbose only

Preferred bug tracker