Bug #83494 for DBD-mysql: Parser is confused by quotes in comments

Wed Feb 20 17:43:59 2013 sveta.smirnova [...] oracle.com - Ticket created

Subject:

Parser is confused by quotes in comments

Originally reported by Raphael Hertzog at http://bugs.mysql.com/bug.php?id=27625 Description: I'm forwarding a bug reported to the Debian bug tracking system. http://bugs.debian.org/311040 The SQL parser is apparently confused by single quotes in comments. Example of problematic SQL query: -- 'Tis the quote that confuses DBI::MySQL SELECT ? DBD::MySQL will miss the "?", and assume there's no parameter to bind. Note that the syntax is valid, and the MySQL server has no problem parsing it (if you replace "?" with something else). How to repeat: $ perl -MDBI -lwe 'print DBI->connect("DBI:mysql:mysql_read_default_file=~/.my.cnf")->selectrow_array("-- \x27 \n SELECT ?", undef, 42)' DBD::mysql::db selectrow_array failed: called with 1 bind variables when 0 are needed at -e line 1. See original bug report for more details.

Tue Oct 08 11:15:30 2013 MICHIELB [...] cpan.org - Correspondence added

Thanks for the bug report. I've added a test here, on latest DBD::mysql the problem no longer exists: https://github.com/perl5-dbi/DBD-mysql/commit/434205de50fd710586b35e388f2c99725b8e443b

Tue Oct 08 11:15:31 2013 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 08 11:15:31 2013 MICHIELB [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Oct 08 11:15:32 2013 MICHIELB [...] cpan.org - Fixed in 4.024 added

Wed Dec 04 10:32:22 2013 TFPBL [...] cpan.org - Correspondence added

Subject:

test t/rt83494-quotes-comments.t doesn't skip on missing database

Hello MICHIELB, The test t/rt83494-quotes-comments.t fails if no database is available, instead of skipping like other tests. t/91errcheck.t ....................... skipped: ERROR: Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock' (2) Can't continue test t/99_bug_server_prepare_blob_null.t .. skipped: ERROR: DBI connect('test;mysql_server_prepare=1','nagios',...) failed: Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock' (2) at t/99_bug_server_prepare_blob_null.t line 16. t/pod.t .............................. ok t/rt83494-quotes-comments.t .......... DBI connect('test','nagios',...) failed: Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock' (2) at t/rt83494-quotes-comments.t line 19. t/rt83494-quotes-comments.t .......... 1/10 Can't call method "prepare" on an undefined value at t/rt83494-quotes-comments.t line 30. t/rt83494-quotes-comments.t .......... Dubious, test returned 255 (wstat 65280, 0xff00) Installing version CAPTTOFU/DBD-mysql-4.024, the tests are all skipped/ok which passes the test suite. Thanks Thomas

Wed Dec 04 10:32:23 2013 TFPBL [...] cpan.org - Status changed from 'resolved' to 'open'

Sun Dec 08 14:58:52 2013 MICHIELB [...] cpan.org - Correspondence added

Hi Thomas, On Wed Dec 04 10:32:22 2013, TFPBL wrote: Show quoted text

> > The test t/rt83494-quotes-comments.t fails if no database is > available, instead of skipping like other tests. > > t/91errcheck.t ....................... skipped: ERROR: Can't connect > to local MySQL server through socket '/var/lib/mysql/mysql.sock' (2) > Can't continue test > t/99_bug_server_prepare_blob_null.t .. skipped: ERROR: DBI > connect('test;mysql_server_prepare=1','nagios',...) failed: Can't > connect to local MySQL server through socket > '/var/lib/mysql/mysql.sock' (2) at t/99_bug_server_prepare_blob_null.t > line 16. > t/pod.t .............................. ok > t/rt83494-quotes-comments.t .......... DBI > connect('test','nagios',...) failed: Can't connect to local MySQL > server through socket '/var/lib/mysql/mysql.sock' (2) at t/rt83494- > quotes-comments.t line 19. > t/rt83494-quotes-comments.t .......... 1/10 Can't call method > "prepare" on an undefined value at t/rt83494-quotes-comments.t line > 30. > t/rt83494-quotes-comments.t .......... Dubious, test returned 255 > (wstat 65280, 0xff00) > > Installing version CAPTTOFU/DBD-mysql-4.024, the tests are all > skipped/ok which passes the test suite.

Thanks for your suggestion. I've improved the test code here: https://github.com/perl5-dbi/DBD-mysql/commit/7dd8c59605d0b90ac0a4b32f3e952f7a292e9705 -- Mike

Sun Dec 08 14:58:53 2013 MICHIELB [...] cpan.org - Status changed from 'open' to 'resolved'