Skip Menu |

This queue is for tickets about the GnuPG-Interface CPAN distribution.

Report information
The Basics
Id: 83466
Status: rejected
Priority: 0/
Queue: GnuPG-Interface

People
Owner: Nobody in particular
Requestors: corsepiu [...] fedoraproject.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: GnuPG::Interface > 0.45 breaks Mail::GnuPG-0.18 's t/agent.t
Date: Wed, 20 Feb 2013 08:29:15 +0100
To: bug-GnuPG-Interface [...] rt.cpan.org
From: Ralf Corsépius <corsepiu [...] fedoraproject.org>
Hi, Mail-GnuPG-0.18's testsuite fails with GnuPG::Interface > 0.45: t/00.signature.t ......... skipped: Set the environment variable TEST_SIGNATURE to enable this test. t/05.load.t .............. ok t/20.inline-verify.t ..... ok t/25.multipart-verify.t .. ok t/30.inline-decrypt.t .... ok t/35.has-public-key.t .... ok t/99.pod.t ............... ok t/agent.t ................ 1/? # Failed test at t/agent.t line 78. # got: '0' # expected: '2' # Failed test at t/agent.t line 81. # got: '0' # expected: '2' # Failed test at t/agent.t line 82. # got: 'EFEA4EAD' # expected: undef # Failed test at t/agent.t line 83. # got: 'Mail::GnuPG Test Key <mail@gnupg.dom>' # expected: undef # Failed test at t/agent.t line 92. # got: '0' # expected: '2' Unknown Content-Type or no PGP message in body at /builddir/build/BUILD/Mail-GnuPG-0.18/blib/lib/Mail/GnuPG.pm line 402. # Looks like you planned 20 tests but ran 8. # Looks like you failed 5 tests of 8 run. # Looks like your test exited with 2 just after 8. t/agent.t ................ Dubious, test returned 2 (wstat 512, 0x200) Failed 17/20 subtests t/base.t ................. ok t/round-trip.t ........... ok The test-suite completes without complaints with GnuPG::Interface-0.44 or 0.45. As things appear to me, something has changed in GnuPG::Interface-0.46, which actually breaks Mail::GnuPG or at least Mail::GnuPG's t/agent.t. Ralf
Subject: Re: [rt.cpan.org #83466] GnuPG::Interface > 0.45 breaks Mail::GnuPG-0.18 's t/agent.t
Date: Wed, 20 Feb 2013 00:31:22 -0800
To: bug-GnuPG-Interface [...] rt.cpan.org
From: Thomas Sibley <tsibley [...] cpan.org>
On 02/19/2013 11:32 PM, Ralf Corsépius via RT wrote: Show quoted text
> As things appear to me, something has changed in GnuPG::Interface-0.46, > which actually breaks Mail::GnuPG or at least Mail::GnuPG's t/agent.t.
Before 0.46, the strict separation of command arguments and options was not enforced [1]. This change, which quite unfortunately missed being included in the ChangeLog for 0.46, appears to be the culprit. Mail::GnuPG should be updated to correctly use ->options instead of passing command_args. Refer to the SYNOPSIS [2] and the first paragraph explaining the various actions/methods available [3]. [1] https://github.com/bestpractical/gnupg-interface/commit/c072c82 [2] https://metacpan.org/module/GnuPG::Interface#SYNOPSIS [3] https://metacpan.org/module/GnuPG::Interface#search_keys