| Subject: | Authen-Krb5-Admin does not compile against krb5-1.11 |
| Date: | Wed, 20 Feb 2013 01:23:19 +0100 |
| To: | bug-Authen-Krb5-Admin [...] rt.cpan.org |
| From: | Christian Krause <chkr [...] plauener.de> |
Due to some cleanup in admin.h of krb5-1.11, Authen-Krb5-Admin does not
compile anymore:
----------------------------------------------------
[...]
Admin.xs: In function 'XS_Authen__Krb5__Admin__Config_DESTROY':
Admin.xs:1509:19: error: 'kadm5_config_params' has no member named
'admin_keytab'
if (config->admin_keytab)
^
In file included from /usr/lib/perl5/CORE/perl.h:2460:0,
from Admin.xs:30:
Admin.xs:1510:28: error: 'kadm5_config_params' has no member named
'admin_keytab'
Safefree(config->admin_keytab);
^
[...]
----------------------------------------------------
It looks like that the admin_keytab parameter was removed in krb5 in the
following commit:
----------------------------------------------------
commit f938afd6b6f61a96a0aa72c57a280aa721566fe6
Author: Greg Hudson <ghudson@mit.edu>
Date: Sun Mar 4 00:38:48 2012 +0000
Remove admin_keytab references in code and docs
The admin keytab hasn't been needed or used by kadmind since 1.4
(except possibly by legacy admin daemons which we no longer ship).
Eliminate remaining references to it in code, test cases, and
documentation.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25729
dc483132-0cff-0310-8789-dd5450dbe970
----------------------------------------------------
The following patch fixes the compile issue. config->admin_keytab does
not seem to be used, so I think removing the two lines should be OK. I
didn't do a functional test so far.
----------------------------------------------------
diff -uNr Authen-Krb5-Admin-0.16.old/Admin.xs
Authen-Krb5-Admin-0.16/Admin.xs
--- Authen-Krb5-Admin-0.16.old/Admin.xs 2012-11-01 10:55:24.000000000 +0100
+++ Authen-Krb5-Admin-0.16/Admin.xs 2013-02-20 00:53:59.769890503 +0100
@@ -1506,8 +1506,6 @@
Safefree(config->keysalts);
if (config->admin_server)
Safefree(config->admin_server);
- if (config->admin_keytab)
- Safefree(config->admin_keytab);
if (config->dict_file)
Safefree(config->dict_file);
if (config->acl_file)
----------------------------------------------------