Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Strict CPAN distribution.

Report information
The Basics
Id: 83433
Status: resolved
Priority: 0/
Queue: Test-Strict
People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.18
Fixed in: (no value)

History Show all quoted text
  Mon Feb 18 15:19:35 2013 ribasushi [...] leporine.io - Ticket created
Subject: New moose-as-strict detection intoduces false negatives (while fixing false positives)
0.17 would correctly (even though by accident) regard use Moose::Role as "strict is on". This not longer works starting from 0.18, resulting in spurious test failures. In general I would recommend copying/extracting standalone the logic used by CPANTS: https://metacpan.org/source/DAXIM/Module-CPANTS-Analyse-0.86/lib/Module/CPANTS/Kwalitee/Uses.pm#L89
  Wed Feb 20 04:39:10 2013 daxim [...] cpan.org - Correspondence added
Great to see T-S is maintained again! Please don't just copy. I would like to externalise these lists so I don't have to maintain it in a distro that only marginally has something to do with it. I propose that you take this list into T-S, because checking for strict is this distro's main purpose, and also expose it with an API. (This is probably what ribasushi meant with "extract".) Then I am able to simply depend on T-S from M-C-A and can remove the lists in the code there.
  Wed Feb 20 04:39:11 2013 The RT System itself - Status changed from 'new' to 'open'
  Wed Feb 20 04:39:59 2013 SZABGAB [...] cpan.org - Correspondence added
On Mon Feb 18 15:19:35 2013, RIBASUSHI wrote: Show quoted text
> 0.17 would correctly (even though by accident) regard > > use Moose::Role > > as "strict is on". This not longer works starting from 0.18, resulting > in spurious test failures. In general I would recommend > copying/extracting standalone the logic used by CPANTS: > https://metacpan.org/source/DAXIM/Module-CPANTS-Analyse- > 0.86/lib/Module/CPANTS/Kwalitee/Uses.pm#L89
Started, please check here: https://github.com/szabgab/Test-Strict
  Wed Feb 20 04:45:09 2013 SZABGAB [...] cpan.org - Correspondence added
DAXIM, Oh I think I understand what you mean.
  Tue Feb 26 13:37:25 2013 SZABGAB [...] cpan.org - Correspondence added
See 0.20
  Tue Feb 26 13:37:28 2013 SZABGAB [...] cpan.org - Status changed from 'open' to 'resolved'