Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 83422
Status: resolved
Priority: 0/
Queue: Pod-Simple

People
Owner: Nobody in particular
Requestors: demerphq [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Fix test fails due to hash traversal randomization
Pod::Simple occasionally fails test when hash iterator randomization is enabled in 5.17.9. The solution is to enable $Pod::Simple::XMLOutStream::SORT_ATTRS mode in the failing test file t/closeys.t We plan to enable hash traversal randomization in 5.18. The attached patch from my perl.git branch yves/hv_h_split fixes the bug. I have marked this patch as important as it is a blocker for 5.18 release.
Subject: 0001-Fix-test-fails-due-to-hash-traversal-randomization.patch
From 9e7b62a91521411e68934310e57f7737119c45ef Mon Sep 17 00:00:00 2001 From: Yves Orton <demerphq@gmail.com> Date: Mon, 18 Feb 2013 07:56:25 +0100 Subject: [PATCH] Fix test fails due to hash traversal randomization One cannot assume two hashes with the same keys will have the the same key order. And after hash traversal randomization one can assume they WONT. --- cpan/Pod-Simple/t/closeys.t | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cpan/Pod-Simple/t/closeys.t b/cpan/Pod-Simple/t/closeys.t index 683ce13..0adf05a 100644 --- a/cpan/Pod-Simple/t/closeys.t +++ b/cpan/Pod-Simple/t/closeys.t @@ -24,6 +24,7 @@ sub nowhine { # $_[0]->{'no_whining'} = 1; $_[0]->accept_targets("*"); } +local $Pod::Simple::XMLOutStream::SORT_ATTRS= 1; &ok(e( "=begin :foo\n\n=begin :bar\n\nZaz\n\n", -- 1.7.5.4
From: demerphq [...] gmail.com
From: demerphq [...] gmail.com
On Mon Feb 18 02:06:11 2013, demerphq@gmail.com wrote: Show quoted text
Seems like this is fixed already 3.25, so all that needs to happen is we update to that version in core. Sorry for the noise! Yves
Yep, already fixed. Thanks!
Subject: Re: [rt.cpan.org #83422] Fix test fails due to hash traversal randomization
Date: Tue, 19 Feb 2013 01:12:33 +0100
To: bug-Pod-Simple [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
On 19 February 2013 01:09, David Wheeler via RT <bug-Pod-Simple@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=83422 > > > Yep, already fixed. Thanks!
Sorry about the noise, but are you aware of downstream breakage reported in: https://rt.perl.org/rt3/Ticket/Display.html?id=116827 cheers Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"
Subject: Re: [rt.cpan.org #83422] Fix test fails due to hash traversal randomization
Date: Mon, 18 Feb 2013 16:19:15 -0800
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Feb 18, 2013, at 4:12 PM, demerphq via RT <bug-Pod-Simple@rt.cpan.org> wrote: Show quoted text
> Sorry about the noise, but are you aware of downstream breakage reported in: > > https://rt.perl.org/rt3/Ticket/Display.html?id=116827
No. Looks like that's due to this change: https://github.com/theory/pod-simple/commit/c58317fd9c3a2190423c1814584c036629d46cba Best, David