Bug #83271 for Dist-Zilla-Plugin-ReadmeFromPod: Don't blindly replace any 'README' found

Mon Feb 11 13:15:12 2013 dagolden [...] cpan.org - Ticket created

Subject:

Don't blindly replace any 'README' found

I had a t/README readme and it was replaced on build by the generated README file. That was completely surprising. I would eliminate that mis-feature or at least constrain it to the root directory of the distribution.

Mon Feb 11 13:41:48 2013 sscaffidi [...] cpan.org - Correspondence added

On Mon Feb 11 13:15:12 2013, DAGOLDEN wrote: Show quoted text

> I had a t/README readme and it was replaced on build by the generated > README file. That was completely surprising. > > I would eliminate that mis-feature or at least constrain it to the root > directory of the distribution.

Indeed, that does seem surprising! I will try to look into this later tonight. In the meantime, can you post the relevant piece of dist.ini you're using to configure the ReadmeFromPod plugin? (maybe even better to post the whole config if you can)

Mon Feb 11 13:41:50 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 11 22:09:29 2013 fayland [...] cpan.org - Correspondence added

I added ^ in the matching code which should fix this issue. my $file = $self->zilla->files->grep( sub { $_->name =~ m{^README\z} } )->head; Thanks.

Mon Feb 11 22:09:30 2013 fayland [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Feb 11 22:58:07 2013 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #83271] Don't blindly replace any 'README' found
Date:	Mon, 11 Feb 2013 22:57:25 -0500
To:	bug-Dist-Zilla-Plugin-ReadmeFromPod [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

On Mon, Feb 11, 2013 at 10:09 PM, Fayland Lin via RT <bug-Dist-Zilla-Plugin-ReadmeFromPod@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=83271 > > > I added ^ in the matching code which should fix this issue. > > my $file = $self->zilla->files->grep( sub { $_->name =~ m{^README\z} } )->head;

That's equivalent to just specifying "README" just as if $file was undef. The only thing that changes is that a different log message is generated. That would fix *my* issue, but you might want to consider if that's why that code needed to be there in the first place. David -- David Golden <dagolden@cpan.org> Take back your inbox! → http://www.bunchmail.com/ Twitter/IRC: @xdg

Mon Feb 11 22:58:07 2013 The RT System itself - Status changed from 'resolved' to 'open'