Skip Menu |

This queue is for tickets about the Convert-Binary-C CPAN distribution.

Report information
The Basics
Id: 83171
Status: stalled
Priority: 0/
Queue: Convert-Binary-C
People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 0.76
Fixed in: (no value)

History Show all quoted text
  Wed Feb 06 14:03:19 2013 RURBAN [...] cpan.org - Ticket created
Subject: member_expr_walker_new heap-buffer-overflow with AddressSanitizer
https://code.google.com/p/address-sanitizer/wiki/AddressSanitizer does not understand the redefinition of the stack var me to the heap in member_expr_walker_new(): Newc(0, me, offsetof(struct member_expr, buf) + len + 1, char, struct member_expr); me->startup = 1; => heap-buffer-overflow I tried to set the __attribute__((no_address_safety_analysis)) to this function, but it did not work. The whole trick smells, but valgrind accepts it. So I guess we have to live with it. -- Reini Urban
  Sun Feb 14 16:55:09 2016 MHX [...] cpan.org - Correspondence added
On Wed Feb 06 14:03:19 2013, RURBAN wrote: Show quoted text
> https://code.google.com/p/address-sanitizer/wiki/AddressSanitizer does > not understand the redefinition of the stack var me to the heap in > member_expr_walker_new(): > Newc(0, me, offsetof(struct member_expr, buf) + len + 1, char, struct > member_expr); > me->startup = 1; => heap-buffer-overflow > > I tried to set the > __attribute__((no_address_safety_analysis)) > to this function, but it did not work. > > The whole trick smells, but valgrind accepts it. > So I guess we have to live with it.
Mmmh, odd. I don't see much wrong with the code (I wouldn't necessarily write it like this anymore, but hey). Any chance you could check if ASAN is still unhappy with it? Thanks!
  Sun Feb 14 16:55:10 2016 The RT System itself - Status changed from 'new' to 'open'
  Sun Feb 14 16:55:21 2016 MHX [...] cpan.org - Status changed from 'open' to 'stalled'