Skip Menu |

This queue is for tickets about the Text-CSV-Hashify CPAN distribution.

Report information
The Basics
Id: 83168
Status: resolved
Priority: 0/
Queue: Text-CSV-Hashify
People
Owner: jkeenan [...] cpan.org
Requestors: MRDVT [...] cpan.org
Cc: jkeenan [...] cpan.org
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.04
Fixed in: (no value)

History Show all quoted text
  Wed Feb 06 13:16:59 2013 MRDVT [...] cpan.org - Ticket created
CC: jkeenan [...] cpan.org
Subject: new(key) param required but not used for format=>aoh
The new constructor requires that "key" be set to a true value but it is not needed for format=>aoh case. for my $el ( qw| file key | ) { croak "Argument to 'new()' must have '$el' element" unless $args->{$el}; } Thanks, Mike mrdvt92
  Wed Feb 06 21:24:42 2013 jkeenan [...] cpan.org - Taken
  Wed Feb 06 21:26:28 2013 jkeenan [...] cpan.org - Correspondence added
On Wed Feb 06 13:16:59 2013, MRDVT wrote: Show quoted text
> The new constructor requires that "key" be set to a true value but it > is not needed for format=>aoh case. > > for my $el ( qw| file key | ) { > croak "Argument to 'new()' must have '$el' element" > unless $args->{$el}; > } > > Thanks, > Mike > > mrdvt92
Good catch! I have made revisions which I have pushed to github: https://github.com/jkeenan/text-csv-hashify Feedback welcome. I will upload a new version to CPAN once I have had a chance to look at the other ticket you filed (https://rt.cpan.org/Ticket/Display.html?id=83169) and some other issues. Thank you very much. Jim Keenan
  Wed Feb 06 21:26:29 2013 The RT System itself - Status changed from 'new' to 'open'
  Wed Feb 06 21:26:41 2013 jkeenan [...] cpan.org - Reference to ticket #83169 added
  Sat Sep 28 08:27:46 2013 jkeenan [...] cpan.org - Correspondence added
On Wed Feb 06 21:26:28 2013, JKEENAN wrote: Show quoted text
> On Wed Feb 06 13:16:59 2013, MRDVT wrote:
> > The new constructor requires that "key" be set to a true value but it > > is not needed for format=>aoh case. > > > > for my $el ( qw| file key | ) { > > croak "Argument to 'new()' must have '$el' element" > > unless $args->{$el}; > > } > > > > Thanks, > > Mike > > > > mrdvt92
> > Good catch! I have made revisions which I have pushed to github: > https://github.com/jkeenan/text-csv-hashify > > Feedback welcome. I will upload a new version to CPAN once I have had a > chance to look at the other ticket you filed > (https://rt.cpan.org/Ticket/Display.html?id=83169) and some other issues. > > Thank you very much. > Jim Keenan
Text-CSV-Hashify v0.05 was pushed to CPAN on Feb 08 2013. I believe this satisfies the request in this ticket. Closing ticket.
  Sat Sep 28 08:27:47 2013 jkeenan [...] cpan.org - Status changed from 'open' to 'resolved'