Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the File-Which CPAN distribution.

Report information
The Basics
Id: 83146
Status: resolved
Priority: 0/
Queue: File-Which
People
Owner: Nobody in particular
Requestors: MITHUN [...] cpan.org
Cc: PLICEASE [...] cpan.org
AdminCc:
Bug Information
Severity: Important
Broken in: 1.09
Fixed in: (no value)

History Show all quoted text
  Tue Feb 05 22:18:15 2013 MITHUN [...] cpan.org - Ticket created
Subject: Fails to find EXEs on cygwin
This is sort of related to #49908. In some cases, EXEs installed via Windows (e.g. java.exe) are not found using `which`. This occurs when the EXE does not have the execute bit set when listed (`ls -l`) via a cygwin shell. However, those EXEs are still executable and run OK. I've attached a patch that seems to work for me. Please consider applying it. Thanks, -- Mithun
Subject: 49908.patch
--- Which.pm 2013-02-02 22:04:00.000000000 -0600 +++ Which.pm.orig 2013-02-02 21:48:26.000000000 -0600 @@ -16,7 +16,6 @@ use constant IS_VMS => ($^O eq 'VMS'); use constant IS_MAC => ($^O eq 'MacOS'); use constant IS_DOS => ($^O eq 'MSWin32' or $^O eq 'dos' or $^O eq 'os2'); -use constant IS_CYG => ($^O eq 'cygwin'); # For Win32 systems, stores the extensions used for # executable files @@ -33,11 +32,6 @@ } } elsif ( IS_VMS ) { push @PATHEXT, qw{.exe .com}; -} elsif ( IS_CYG ) { - - # See this for more info - # http://cygwin.com/cygwin-ug-net/using-specialnames.html#pathnames-exe - push @PATHEXT, qw{.exe}; } sub which { @@ -95,7 +89,7 @@ IS_MAC || ( - ( IS_DOS or IS_CYG ) + IS_DOS and grep { $file =~ /$_\z/i
  Mon Feb 02 19:54:14 2015 ether [...] cpan.org - Correspondence added
Instead of hardcoding '.exe', use $Config{_exe}.
  Mon Feb 02 19:54:15 2015 The RT System itself - Status changed from 'new' to 'open'
  Tue Feb 03 07:59:03 2015 PLICEASE [...] cpan.org - Correspondence added
After further testing I see that cygwin supports .com and .exe but not .bat or PATHEXT diff --git a/lib/File/Which.pm b/lib/File/Which.pm index 327e8b4..06cefe3 100644 --- a/lib/File/Which.pm +++ b/lib/File/Which.pm @@ -16,6 +16,7 @@ BEGIN { use constant IS_VMS => ($^O eq 'VMS'); use constant IS_MAC => ($^O eq 'MacOS'); use constant IS_DOS => ($^O eq 'MSWin32' or $^O eq 'dos' or $^O eq 'os2'); +use constant IS_CYG => ($^O eq 'cygwin'); # For Win32 systems, stores the extensions used for # executable files @@ -32,6 +33,10 @@ if ( IS_DOS ) { } } elsif ( IS_VMS ) { push @PATHEXT, qw{.exe .com}; +} elsif ( IS_CYG ) { + # See this for more info + # http://cygwin.com/cygwin-ug-net/using-specialnames.html#pathnames-exe + push @PATHEXT, qw{.exe .com}; } sub which { @@ -89,7 +94,7 @@ sub which { IS_MAC || ( - IS_DOS + ( IS_DOS or IS_CYG ) and grep { $file =~ /$_\z/i
  Tue Feb 03 08:00:00 2015 PLICEASE [...] cpan.org - Correspondence added
On Mon Feb 02 19:54:14 2015, ETHER wrote: Show quoted text
> Instead of hardcoding '.exe', use $Config{_exe}.
In this case $Config{_exe} is wrong. It covers the .exe case but not .com.
  Tue Feb 03 08:03:24 2015 PLICEASE [...] cpan.org - Cc PLICEASE added
  Tue Feb 03 08:22:02 2015 PLICEASE [...] cpan.org - Correspondence added
On Tue Feb 03 08:00:00 2015, PLICEASE wrote: Show quoted text
> On Mon Feb 02 19:54:14 2015, ETHER wrote:
> > Instead of hardcoding '.exe', use $Config{_exe}.
> > In this case $Config{_exe} is wrong. It covers the .exe case but not .com.
"wrong" is a strong word, what I mean to say is that $Config{_exe} does not cover all cases.
  Thu Mar 26 04:56:53 2015 PLICEASE [...] cpan.org - Correspondence added
This will be fixed in 1.10. Please let me know if you find this not to be the case.
  Thu Mar 26 04:56:54 2015 PLICEASE [...] cpan.org - Status changed from 'open' to 'resolved'