Skip Menu |

This queue is for tickets about the Class-Method-Modifiers CPAN distribution.

Report information
The Basics
Id: 83099
Status: resolved
Priority: 0/
Queue: Class-Method-Modifiers

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.02
Fixed in: 2.03



Subject: Fails during Makefile.PL with high probability
The new Makefile.PL contains two more 'use' statements for modules that are usually not installed on the target system nor included in inc/ nor declared as configure_requires. @@ -1,13 +1,19 @@ # Load the Module::Install bundled in ./inc/ use inc::Module::Install; use Module::Install::AuthorRequires; +use Module::Install::ReadmeFromPod; use Module::Install::GithubMeta; +use Module::Install::AutoLicense; So how should this ever work? My smokers have not yet sent out a single PASS, FAIL or UNKNOWN, but all dependencies of Class-Method-Modifiers are now blocked. Hmmm. Installing ReadmeFromPod and AutoLicense does not provide a workaround. I now get String found where operator expected at Makefile.PL line 11, near "readme_from 'lib/Class/Method/Modifiers.pm'" (Do you need to predeclare readme_from?) syntax error at Makefile.PL line 11, near "readme_from 'lib/Class/Method/Modifiers.pm'" Bareword "auto_license" not allowed while "strict subs" in use at Makefile.PL line 11. Execution of Makefile.PL aborted due to compilation errors. Sounds familiar to me, somethign to do with forced export of strictness in Module::Install or so. Where was that? Ahh, here: https://rt.cpan.org/Ticket/Display.html?id=76035 HTH&&Regards,
From: mascip [...] gmail.com
Exact same problem here which threatened to prevent me from installing Moo. I installed version 2.01, which did the trick.
Subject: Re: [rt.cpan.org #83099] Fails during Makefile.PL with high probability
Date: Fri, 1 Feb 2013 23:15:20 -0800
To: Andreas Koenig via RT <bug-Class-Method-Modifiers [...] rt.cpan.org>
From: Karen Etheridge <ether [...] cpan.org>
On Fri, Feb 01, 2013 at 11:16:58PM -0500, Andreas Koenig via RT wrote: Show quoted text
> The new Makefile.PL contains two more 'use' statements for modules that > are usually not installed on the target system nor included in inc/ nor > declared as configure_requires.
My bad; fixing.
On Fri Feb 01 23:15:31 2013, ETHER wrote: Show quoted text
> On Fri, Feb 01, 2013 at 11:16:58PM -0500, Andreas Koenig via RT wrote:
> > The new Makefile.PL contains two more 'use' statements for modules that > > are usually not installed on the target system nor included in inc/ nor > > declared as configure_requires.
> > My bad; fixing.
Actually I don't think it was me (well I added some new plugins, but I didn't do it incorrectly..) I'm no Module::Install expert, but https://metacpan.org/module/ADAMK/Module-Install-1.06/lib/Module/Install/FAQ.pod#Should-I-put-an-inc-directory-Module::Install-automatically-creates-into-a-repository-for-my-projects- does suggest that it's safe to add extra 'use Module::Install::Foo' statements into Makefile.PL. I've just done a new build from the 2.02 release and my inc/ does contain the new modules, so I'll assume that sartak didn't do a clean 'make manifest' before this release. I'll push up a new release now.
RT-Send-CC: mascip [...] gmail.com
2.03 has been released. Please reply/reopen if things still seem amiss!
From: mascip [...] gmail.com
Wow, i've never seen a fix released this fast cheers :-) All's well here now!