Skip Menu |

This queue is for tickets about the Jifty-DBI CPAN distribution.

Report information
The Basics
Id: 82978
Status: resolved
Priority: 0/
Queue: Jifty-DBI

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.74
Fixed in: (no value)



Subject: Test failures due to hash randomisation in perl 5.17.6
Since bleadperl v5.17.5-518-g7dc8663 your tests are failing frequently. That commit introduced hash key randomization and it seems at least the test t/10schema.t is hit by that. Sample fail reports are on the way to the cpantesters. Here a small excerpt: # got: 'CREATE TABLE employees (id INTEGER PRIMARY KEY AUTOINCREMENT NO T NULL , dexterity integer , name varchar , label varchar , type varchar); CREAT E INDEX employees1 ON employees (name); CREATE TABLE addresses (id INTEGER PRIMA RY KEY AUTOINCREMENT NOT NULL , employee_id integer , name varchar DEFAULT 'Frank' , phone varchar);' # expected: 'CREATE TABLE addresses (id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL , employee_id integer , name varchar DEFAULT 'Frank' , phone varchar); CREATE TABLE employees (id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL , dexterity integer , name varchar , label varchar , type varchar); CREATE INDEX employees1 ON employees (name);' You can read more about the change at http://perl5.git.perl.org/perl.git/commit/7dc8663964c66a698d31bbdc8e8abed69bddeec3 or at http://www.perlmonks.org/?node_id=1005122 You may have to run the test several times until the randomization causes a fail. HTH&&Thanks&&Regards,
On Sun Jan 27 01:11:24 2013, ANDK wrote: Show quoted text
> Since bleadperl v5.17.5-518-g7dc8663 your tests are failing > frequently. > That commit introduced hash key randomization and it seems at least > the test > > t/10schema.t > > is hit by that. Sample fail reports are on the way to the cpantesters.
Thanks for the report. This is actually a problem in DBIx::DBSchema, which Jifty::DBI::SchemaGenerator relies on. In particular, this line: https://metacpan.org/source/IVAN/DBIx-DBSchema-0.40/DBSchema.pm#L198 which is used by the "sql" method 30 lines below it. I've reported a bug in DBIx::DBSchema: https://rt.cpan.org/Ticket/Display.html?id=83035 Thomas
On Tue Jan 29 14:47:28 2013, TSIBLEY wrote: Show quoted text
> Thanks for the report. This is actually a problem in DBIx::DBSchema, > which Jifty::DBI::SchemaGenerator relies on. In particular, this line: > > https://metacpan.org/source/IVAN/DBIx-DBSchema-0.40/DBSchema.pm#L198
I worked around this bug, and released Jifty::DBI 0.75. The fix is 3922e87 in git.