Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Module-Starter CPAN distribution.

Report information
The Basics
Id: 82937
Status: open
Priority: 0/
Queue: Module-Starter

People
Owner: Nobody in particular
Requestors: djerius [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.60
Fixed in: (no value)



Subject: Template plugin doesn't handle ignores properly
ignores_guts in the Template plugin doesn't pay attention to the ignores type passed to it, always using the "ignores" file. The attached patch against 1.60 uses $type as a filename, falling back to "ignores" if it is not available.
Subject: template_plugins.patch
# This is a patch for Module-Starter-1.60.orig to update it to Module-Starter-1.60 # # To apply this patch: # STEP 1: Chdir to the source directory. # STEP 2: Run the 'applypatch' program with this patch file as input. # # If you do not have 'applypatch', it is part of the 'makepatch' package # that you can fetch from the Comprehensive Perl Archive Network: # http://www.perl.com/CPAN/authors/Johan_Vromans/makepatch-x.y.tar.gz # In the above URL, 'x' should be 2 or higher. # # To apply this patch without the use of 'applypatch': # STEP 1: Chdir to the source directory. # STEP 2: Run the 'patch' program with this file as input. # #### End of Preamble #### #### Patch data follows #### diff -c 'Module-Starter-1.60.orig/lib/Module/Starter/Plugin/Template.pm' 'Module-Starter-1.60/lib/Module/Starter/Plugin/Template.pm' Index: ./lib/Module/Starter/Plugin/Template.pm *** ./lib/Module/Starter/Plugin/Template.pm Thu Oct 25 14:32:15 2012 --- ./lib/Module/Starter/Plugin/Template.pm Thu Jan 24 14:44:30 2013 *************** *** 223,230 **** sub ignores_guts { my $self = shift; ! my $template = $self->{templates}{ignores}; $self->render($template); } --- 223,234 ---- sub ignores_guts { my $self = shift; + my $type = shift; ! my $template = defined $self->{templates}{$type} ! ? $self->{templates}{$type} ! : $self->{templates}{ignores} ! ; $self->render($template); } #### End of Patch data #### #### ApplyPatch data follows #### # Data version : 1.0 # Date generated : Thu Jan 24 14:44:51 2013 # Generated by : makepatch 2.04 # Recurse directories : Yes # Excluded files : (\A|/).*\~\Z # (\A|/).*\.a\Z # (\A|/).*\.bak\Z # (\A|/).*\.BAK\Z # (\A|/).*\.elc\Z # (\A|/).*\.exe\Z # (\A|/).*\.gz\Z # (\A|/).*\.ln\Z # (\A|/).*\.o\Z # (\A|/).*\.obj\Z # (\A|/).*\.olb\Z # (\A|/).*\.old\Z # (\A|/).*\.orig\Z # (\A|/).*\.rej\Z # (\A|/).*\.so\Z # (\A|/).*\.Z\Z # (\A|/)\.del\-.*\Z # (\A|/)\.make\.state\Z # (\A|/)\.nse_depinfo\Z # (\A|/)core\Z # (\A|/)tags\Z # (\A|/)TAGS\Z # p 'lib/Module/Starter/Plugin/Template.pm' 5095 1359056670 0100644 #### End of ApplyPatch data #### #### End of Patch kit [created: Thu Jan 24 14:44:51 2013] #### #### Patch checksum: 61 2069 81 #### #### Checksum: 79 2770 58434 ####
This issue has been copied to: https://github.com/xsawyerx/module-starter/issues/34. Please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with. On Thu Jan 24 14:51:48 2013, DJERIUS wrote: Show quoted text
> ignores_guts in the Template plugin doesn't pay attention to the ignores > type passed to it, always using the "ignores" file. The attached patch > against 1.60 uses $type as a filename, falling back to "ignores" if it > is not available.