Bug #82934 for WebService-Yahoo-BOSS:

Thu Jan 24 12:17:32 2013 achimru [...] gmail.com - Ticket created

The count parameter for the BOSS web search is hardcoded to 10. However, Yahoo allows to retrieve up to 50 results for the Web search type http://developer.yahoo.com/boss/search/boss_api_guide/v2_univer_api_args.html , this parameter should not be hardcoded (a default of 10 is good though). Side note: allowing to use the LimitedWeb search type would be nice too.

Thu Jan 24 12:58:09 2013 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #82934]
Date:	Thu, 24 Jan 2013 09:57:50 -0800
To:	bug-WebService-Yahoo-BOSS [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

Patches welcome! On Jan 24, 2013 9:17 AM, "Achim Ruopp via RT" < bug-WebService-Yahoo-BOSS@rt.cpan.org> wrote: Show quoted text

> Thu Jan 24 12:17:32 2013: Request 82934 was acted upon. > Transaction: Ticket created by ACHIMRU > Queue: WebService-Yahoo-BOSS > Subject: (No subject given) > Broken in: 0.07 > Severity: Normal > Owner: Nobody > Requestors: ACHIMRU@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82934 > > > > The count parameter for the BOSS web search is hardcoded to 10. However, > Yahoo allows to retrieve up to 50 results for the Web search type > > http://developer.yahoo.com/boss/search/boss_api_guide/v2_univer_api_args.html > , this parameter should not be hardcoded (a default of 10 is good though). > > Side note: allowing to use the LimitedWeb search type would be nice too. >

Thu Jan 24 12:58:10 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 24 12:58:30 2013 achimru [...] gmail.com - Correspondence added

Subject:

Count parameter for the BOSS web search is hardcoded to 10

Setting subject.

Thu Jan 24 16:13:17 2013 achimru [...] gmail.com - Correspondence added

Subject:	Minimal patch
RT-Send-CC:	fred [...] redhotpenguin.com

Here is a patch for the hardcoded count issue. I did not patch the lack of support for the limitedweb Yahoo search: 1) Changing the way the initialization of the service url is set up requires more changes and I didn't want to presume a best way to fix this. 2) I'm not sure how to enable limitedweb in the best way to also allow enabling things like image search etc. in the future.

Subject:

patch.diff

--- BOSS_orig.pm 2013-01-24 20:53:05.000000000 +0000 +++ BOSS.pm 2013-01-24 20:57:58.000000000 +0000 @@ -46,7 +46,7 @@ } $args{format} ||= 'json'; - $args{count} = 10; + $args{count} ||= 10; die 'only json format supported, xml patches welcome' unless $args{format} eq 'json';

Thu Jan 24 16:40:21 2013 PHRED [...] cpan.org - Correspondence added

Resolved - 0.08 is enroute to cpan. Thanks!

Thu Jan 24 16:40:22 2013 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'