Bug #82930 for Tickit: 0.26 causes display corruption through failed updates

Thu Jan 24 07:35:21 2013 leonerd-cpan [...] leonerd.org.uk - Ticket created

Subject:

0.26 causes display corruption through failed updates

Something in 0.26 has broken display updates. Regions of the screen fail to update after a while, causing the display to get more and more out of date. Works fine in 0.25. I suspect some logic around the rect/rectset migration into XS code. More investigation required. Until then I recommend not using 0.26 at all - stick with 0.25. -- Paul Evans

Thu Jan 24 18:59:45 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Yup; this confirms it: my $subwin = $rootwin->make_sub( 2, 2, 20, 50 ); my $exposed = 0; $subwin->set_on_expose( sub { $exposed++ } ); for ( 1 .. 100 ) { $subwin->expose( Tickit::Rect->new( top => 1, left => 1, lines => 3, cols => 20 ) ); flush_tickit; } is( $exposed, 100, '$exposed 100 times' ); # Failed test '$exposed 100 times' # at t/12window-expose.t line 120. # got: '12' # expected: '100' Reliably always 12. Not quite sure why. -- Paul Evans

Thu Jan 24 18:59:45 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'open'

Thu Jan 24 19:28:45 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Found it. Bug in libtickit which erroneously caused a TickitRectSet to try to grow the memory size of the object for every call to tickit_rectset_add(). Now fixed and the test passes. -- Paul Evans

Subject:

rt82930.patch

=== modified file 'src/rectset.c' --- src/rectset.c2013-01-04 19:17:57 +0000 +++ src/rectset.c2013-01-25 00:24:44 +0000 @@ -62,7 +62,7 @@ static int insert_rect(TickitRectSet *trs, const TickitRect *r) { - if(trs->count + 1 < trs->size) { + if(trs->count + 1 > trs->size) { TickitRect *newrects = realloc(trs->rects, trs->size * 2 * sizeof(trs->rects[0])); if(!newrects) return 0;

Thu Jan 24 19:28:46 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Thu Jan 24 19:43:31 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Now released as 0.27. -- Paul Evans

Thu Jan 24 19:43:31 2013 The RT System itself - Status changed from 'patched' to 'open'

Tue Jan 29 05:26:28 2013 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Released as 0.27 -- Paul Evans

Tue Jan 29 05:26:29 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'resolved'

Tue Jan 29 05:26:40 2013 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.27 added