Bug #82899 for SQL-Translator: Remaining leaks in SQLT object hierarchy

Wed Jan 23 06:00:07 2013 ribasushi [...] leporine.io - Ticket created

CC:	ilmari+cpan [...] ilmari.org
Subject:	Remaining leaks in SQLT object hierarchy

It seems that a lot of the circular-ref leakage in SQLT has been solved by the Moo migration, ilmari++. However there are still some left. Just leaving this here as a placeholder. Leaks are evident when commenting out this part of the DBIC leaktrace test: https://github.com/dbsrgits/dbix-class/blob/master/t/52leaks.t#L363

Wed Jan 23 06:30:00 2013 ilmari [...] ilmari.org - Correspondence added

CC:	darren [...] cpan.org
Subject:	Re: [rt.cpan.org #82899] Remaining leaks in SQLT object hierarchy
Date:	Wed, 23 Jan 2013 12:29:43 +0100
To:	bug-SQL-Translator [...] rt.cpan.org
From:	ilmari [...] ilmari.org (Dagfinn Ilmari Mannsåker)

"Peter Rabbitson via RT" <bug-SQL-Translator@rt.cpan.org> writes: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=82899 > > > It seems that a lot of the circular-ref leakage in SQLT has been solved > by the Moo migration, ilmari++. However there are still some left. Just > leaving this here as a placeholder. > > Leaks are evident when commenting out this part of the DBIC leaktrace > test: https://github.com/dbsrgits/dbix-class/blob/master/t/52leaks.t#L363

That's not a leak, the SQLite producer is just hanging on to two DDL generators, one quoting and one not. https://github.com/dbsrgits/sql-translator/blob/master/lib/SQL/Translator/Producer/SQLite.pm#L39 I'll make the test allow one and only one object for each value of quote_chars. -- "A disappointingly low fraction of the human race is, at any given time, on fire." - Stig Sandbeck Mathisen

Wed Jan 23 06:30:01 2013 The RT System itself - Status changed from 'new' to 'open'

Wed Jan 23 06:40:08 2013 ribasushi [...] leporine.io - Correspondence added

On Wed Jan 23 06:30:00 2013, ilmari@ilmari.org wrote: Show quoted text

> "Peter Rabbitson via RT" <bug-SQL-Translator@rt.cpan.org> writes: >

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=82899 > > > > > It seems that a lot of the circular-ref leakage in SQLT has been

> solved

> > by the Moo migration, ilmari++. However there are still some left.

> Just

> > leaving this here as a placeholder. > > > > Leaks are evident when commenting out this part of the DBIC

> leaktrace

> > test: https://github.com/dbsrgits/dbix-

> class/blob/master/t/52leaks.t#L363 > > That's not a leak, the SQLite producer is just hanging on to two DDL > generators, one quoting and one not.

Duh! Of course, sorry for not looking before filing. Show quoted text

> > I'll make the test allow one and only one object for each value of > quote_chars. >

Excellent, thank you!

Wed Jan 23 07:59:19 2013 ribasushi [...] leporine.io - Correspondence added

Turned out to be a non-issue, DBIC leaktest adjusted: https://github.com/dbsrgits/dbix-class/commit/60fd7c3

Wed Jan 23 07:59:22 2013 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'