Skip Menu |

This queue is for tickets about the Net-OAuth2 CPAN distribution.

Report information
The Basics
Id: 82878
Status: resolved
Priority: 0/
Queue: Net-OAuth2

People
Owner: Nobody in particular
Requestors: shmuelfomberg [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Documentation on the token_scheme parameter
I'm working now with the GitHub API, and it seen to want that the auth header will have the 'bearer' string inside, and in the terms of this module, I had to specify in Net::OAuth2::Profile::WebServer->new: token_scheme => 'auth-header:Bearer', It probably should be documented that you chose to use the 'OAuth' string there, even if it is not standard. Also document the different options. something like: ----------- Specify the method to submit authenticated requests to the service. By default, add the access token as a header, such as: "Authorization: OAuth TOKEN". Some services require that the header will be different, i.e. "Authorization: Bearer TOKEN", for which case specify token_scheme => 'auth-header:Bearer'. To add the access token as a uri-parameter: 'uri-query:oauth_token' (in this case, the parameter name will be oauth_token) To add the access token inside a form body: 'form-body:oauth_token' ----------- I'm sure that the it can be greatly improve, as English is not my first language... Thanks for the module, Shmuel.
Subject: Re: [rt.cpan.org #82878] Documentation on the token_scheme parameter
Date: Sat, 26 Jan 2013 22:40:46 +0100
To: Shmuel Fomberg via RT <bug-Net-OAuth2 [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* Shmuel Fomberg via RT (bug-Net-OAuth2@rt.cpan.org) [130122 06:49]: Show quoted text
> Tue Jan 22 01:48:55 2013: Request 82878 was acted upon. > Transaction: Ticket created by SEMUELF > Queue: Net-OAuth2 > Subject: Documentation on the token_scheme parameter > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82878 > > > > I'm working now with the GitHub API, and it seen to want that the > auth header will have the 'bearer' string inside, and in the terms > of this module, I had to specify in > token_scheme => 'auth-header:Bearer',
Last month, I took over this module plus its flaws. It seems that OAuth2 servers in the beginning often used the same token as OAuth(1) But, I think we should move onwards: I will break backwards compatibility with release 0.53, coming tonight. I took your documentation addition as well. -- Thanks! MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
On Sat Jan 26 16:40:56 2013, Mark@Overmeer.net wrote: Show quoted text
> * Shmuel Fomberg via RT (bug-Net-OAuth2@rt.cpan.org) [130122 06:49]:
> > Tue Jan 22 01:48:55 2013: Request 82878 was acted upon. > > Transaction: Ticket created by SEMUELF > > Queue: Net-OAuth2 > > Subject: Documentation on the token_scheme parameter > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82878 > > > > > > > I'm working now with the GitHub API, and it seen to want that the > > auth header will have the 'bearer' string inside, and in the terms > > of this module, I had to specify in > > token_scheme => 'auth-header:Bearer',
> > Last month, I took over this module plus its flaws. It seems that > OAuth2 servers in the beginning often used the same token as OAuth(1) > > But, I think we should move onwards: I will break backwards > compatibility with release 0.53, coming tonight. > > I took your documentation addition as well.
I don't see where the documentation is included... If I understand correctly, now the default is to use "Bearer" in the auth header. which I agree is good idea. Thanks for the new version. Shmuel.
Subject: Re: [rt.cpan.org #82878] Documentation on the token_scheme parameter
Date: Tue, 29 Jan 2013 08:53:53 +0100
To: Shmuel Fomberg via RT <bug-Net-OAuth2 [...] rt.cpan.org>
From: Mark Overmeer <solutions [...] overmeer.net>
* Shmuel Fomberg via RT (bug-Net-OAuth2@rt.cpan.org) [130129 07:00]: Show quoted text
> Queue: Net-OAuth2 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82878 > >
> > I took your documentation addition as well.
> I don't see where the documentation is included...
Net::OAuth2::Profile::new(token_scheme) Show quoted text
> Thanks for the new version.
Thanks for the contributions ;-) -- MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
thanks.