Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Data-Compare CPAN distribution.

Report information
The Basics
Id: 82849
Status: rejected
Priority: 0/
Queue: Data-Compare
People
Owner: Nobody in particular
Requestors: NKH [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jan 21 04:20:45 2013 NKH [...] cpan.org - Ticket created
Subject: use File::Find::Rule in string eval is not checked
sub register_plugins { eval 'use File::Find::Rule'; # no verification that File::Find::Rule was found on the local machine
  Sat Jan 26 19:40:20 2013 dcantrell [...] cpan.org - Correspondence added
On Mon Jan 21 04:20:45 2013, NKH wrote: Show quoted text
> sub register_plugins { > eval 'use File::Find::Rule'; > > # no verification that File::Find::Rule was found on the local machine
It's only in an eval to avoid loading the module in the case that we don't look for any plugins at all, such as if taint mode is on or the user loads the module thus: 'use Data::Compare ()'. There's no need to verify that File::Find::Rule can be found, because it's listed as a pre-requisite in Makefile.PL. Under normal circumstances, Data::Compare can't even be *installed* if File::Find::Rule isn't present, and the usual tools for installing Data::Compare will install File::Find::Rule as well if necessary. There are ways around that, of course, but I consider that any user who does that ought to know that it's gonna break if he doesn't resolve the missing dependency himself.
  Sat Jan 26 19:40:22 2013 The RT System itself - Status changed from 'new' to 'open'
  Sat Jan 26 19:40:22 2013 dcantrell [...] cpan.org - Status changed from 'open' to 'rejected'