Skip Menu |

This queue is for tickets about the forks CPAN distribution.

Report information
The Basics
Id: 82781
Status: resolved
Priority: 0/
Queue: forks
People
Owner: RYBSKEJ [...] cpan.org
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.34
Fixed in: 0.35

History Show all quoted text
  Thu Jan 17 02:53:10 2013 CHORNY [...] cpan.org - Ticket created
Subject: questions in Makefile.PL
Questions in Makefile.PL prevent cpantesters smoker from functioning correctly: they cannot test this module and smoker hangs. Please use prompt from ExtUtils::MakeMaker. Also, environment variables PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip questions. -- Alexandr Ciornii, http://chorny.net
  Mon Dec 09 11:31:53 2013 SREZIC [...] cpan.org - Correspondence added
On 2013-01-17 02:53:10, CHORNY wrote: Show quoted text
> Questions in Makefile.PL prevent cpantesters smoker from functioning > correctly: they cannot test this module and smoker hangs. Please use > prompt from ExtUtils::MakeMaker. Also, environment variables > PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip questions.
It seems that Makefile.PL tries to emulate a subset of prompt() functionality (unfortunately this subset does not include default answers if PERL_MM_USE_DEFAULT is set) to keep compatibility with very old installations. I think this can be easily fixed by using something like: if (!defined &prompt) { *prompt = sub { # the compatibility code comes here }; } if (prompt("text", "y") eq "y") { # ... } This would work both with very old perl installations and with batch installation or automatic test systems. Regards, Slaven
  Mon Dec 09 11:31:54 2013 The RT System itself - Status changed from 'new' to 'open'
  Wed Jun 25 02:42:40 2014 RYBSKEJ [...] cpan.org - Correspondence added
On Mon Dec 09 11:31:53 2013, SREZIC wrote: Show quoted text
> On 2013-01-17 02:53:10, CHORNY wrote:
> > Questions in Makefile.PL prevent cpantesters smoker from functioning > > correctly: they cannot test this module and smoker hangs. Please use > > prompt from ExtUtils::MakeMaker. Also, environment variables > > PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip > > questions.
> > It seems that Makefile.PL tries to emulate a subset of prompt() > functionality (unfortunately this subset does not include default > answers if PERL_MM_USE_DEFAULT is set) to keep compatibility with very > old installations. I think this can be easily fixed by using something > like: > > if (!defined &prompt) { > *prompt = sub { > # the compatibility code comes here > }; > } > if (prompt("text", "y") eq "y") { > # ... > } > > This would work both with very old perl installations and with batch > installation or automatic test systems. > > Regards, > Slaven
Thanks for the suggestion, I'll plan to integrate it for next release.
  Wed Jun 25 02:42:41 2014 RYBSKEJ [...] cpan.org - Taken
  Wed Jun 25 02:42:41 2014 RYBSKEJ [...] cpan.org - Fixed in 0.34 added
  Wed Jun 25 12:02:10 2014 RYBSKEJ [...] cpan.org - Fixed in 0.34 deleted
  Wed Jun 25 22:20:31 2014 RYBSKEJ [...] cpan.org - Correspondence added
On Wed Jun 25 02:42:40 2014, RYBSKEJ wrote: Show quoted text
> On Mon Dec 09 11:31:53 2013, SREZIC wrote:
> > On 2013-01-17 02:53:10, CHORNY wrote:
> > > Questions in Makefile.PL prevent cpantesters smoker from functioning > > > correctly: they cannot test this module and smoker hangs. Please use > > > prompt from ExtUtils::MakeMaker. Also, environment variables > > > PERL_MM_USE_DEFAULT or AUTOMATED_TESTING can be used to skip > > > questions.
> > > > It seems that Makefile.PL tries to emulate a subset of prompt() > > functionality (unfortunately this subset does not include default > > answers if PERL_MM_USE_DEFAULT is set) to keep compatibility with very > > old installations. I think this can be easily fixed by using something > > like: > > > > if (!defined &prompt) { > > *prompt = sub { > > # the compatibility code comes here > > }; > > } > > if (prompt("text", "y") eq "y") { > > # ... > > } > > > > This would work both with very old perl installations and with batch > > installation or automatic test systems. > > > > Regards, > > Slaven
> > Thanks for the suggestion, I'll plan to integrate it for next release.
Fixed in 0.35 release.
  Wed Jun 25 22:20:32 2014 RYBSKEJ [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed Jun 25 22:20:33 2014 RYBSKEJ [...] cpan.org - Fixed in 0.35 added