Bug #82611 for Win32-API: make tool detection broken in Win32::API

Thu Jan 10 02:26:07 2013 BULKDD [...] cpan.org - Ticket created

CC:	walde.christian [...] googlemail.com
Subject:	make tool detection broken in Win32::API

see http://www.cpantesters.org/cpan/report/621df9ed-7059-1014-86e5-1b72d871b27e http://www.cpantesters.org/cpan/report/9af18357-71e1-1014-8cab-46ee168fd208 somehow Show quoted text

_______________________________________ sub MY::post_constants { return 'CCFLAGS '.($_[0]->{MAKE} =~ /^make/ || $_[0]->{MAKE} =~ /^dmake/ ? ':=' : '=') . ' $(CCFLAGS) '.GS_flag()."\n"; }

________________________________________ isn't working correctly.

Tue Jan 22 14:41:02 2013 BULKDD [...] cpan.org - Correspondence added

RT-Send-CC:

walde.christian [...] googlemail.com

On Thu Jan 10 02:26:07 2013, BULKDD wrote: Show quoted text

> see >

http://www.cpantesters.org/cpan/report/621df9ed-7059-1014-86e5-1b72d871b27e Show quoted text

>

http://www.cpantesters.org/cpan/report/9af18357-71e1-1014-8cab-46ee168fd208 Show quoted text

> > somehow > _______________________________________ > sub MY::post_constants { > return 'CCFLAGS '.($_[0]->{MAKE} =~ /^make/ || $_[0]->{MAKE} =~ > /^dmake/ ? ':=' : '=') > . ' $(CCFLAGS) '.GS_flag()."\n"; > } > ________________________________________ > > isn't working correctly.

After discussion with Mithaldu/smoker owner above, {MAKE} is 'C:\Perl\site\bin\dmake.exe', not 'dmake.exe' on his machine. MM_Win32.pm has a is_make_type method which uses a more elaborate RE to do it. Using is_make_type will probably be the solution. Remaining issues are, is_make_type is not public API of EUMM (embedding the RE is the alternative), and testing the whole thing on VC Perl, S Perl and Cyg Perl.

Tue Jan 22 14:41:03 2013 BULKDD [...] cpan.org - Status changed from 'new' to 'open'

Mon Feb 04 01:43:52 2013 BULKDD [...] cpan.org - Correspondence added

On Tue Jan 22 14:41:02 2013, BULKDD wrote: Show quoted text

> > After discussion with Mithaldu/smoker owner above, {MAKE} is > 'C:\Perl\site\bin\dmake.exe', not 'dmake.exe' on his machine. > MM_Win32.pm has a is_make_type method which uses a more elaborate RE to > do it. Using is_make_type will probably be the solution. Remaining > issues are, is_make_type is not public API of EUMM (embedding the RE is > the alternative), and testing the whole thing on VC Perl, S Perl and Cyg > Perl.

Also remove the Encode:: dependency in makefile.pl, add a dependency on Encode::compat, on 5.8 and newer on Win32 Encode::compat passes, http://www.cpantesters.org/distro/E/Encode-compat.html . So this might have Perl 5.6 reports show up in cpantesters for Win32::API. Also add skipping the native threads with API::Callback threads test that crashes on 5.6.

Wed Feb 06 23:28:10 2013 BULKDD [...] cpan.org - Correspondence added

On Mon Feb 04 01:43:52 2013, BULKDD wrote: Show quoted text

> On Tue Jan 22 14:41:02 2013, BULKDD wrote:

> > > > After discussion with Mithaldu/smoker owner above, {MAKE} is > > 'C:\Perl\site\bin\dmake.exe', not 'dmake.exe' on his machine. > > MM_Win32.pm has a is_make_type method which uses a more elaborate RE to > > do it. Using is_make_type will probably be the solution. Remaining > > issues are, is_make_type is not public API of EUMM (embedding the RE is > > the alternative), and testing the whole thing on VC Perl, S Perl and Cyg > > Perl.

> > Also remove the Encode:: dependency in makefile.pl, add a dependency on > Encode::compat, on 5.8 and newer on Win32 Encode::compat passes, > http://www.cpantesters.org/distro/E/Encode-compat.html . So this might > have Perl 5.6 reports show up in cpantesters for Win32::API. Also add > skipping the native threads with API::Callback threads test that crashes > on 5.6.

Also improve the POD for how to pass NULL, in pack letter mode (NOT prototype mode) for a 'P'. In prototype mode undef is NULL, but in letter mode, 0 is NULL. There is live code (irc conversation) that uses letter mode 0 for NULL. so dont break back compat see this old ::API https://github.com/bulk88/perl5-win32-api/blob/067439edfd8fab5bc7f18f5bfb16fe7ff7a75259 /API.xs#L324

Wed Feb 20 02:15:34 2013 BULKDD [...] cpan.org - Correspondence added

On Wed Feb 06 23:28:10 2013, BULKDD wrote: Show quoted text

> Also improve the POD for how to pass NULL, in pack letter mode (NOT > prototype mode) for a 'P'. In prototype mode undef is NULL, but in > letter mode, 0 is NULL. There is live code (irc conversation) that > uses > letter mode 0 for NULL. so dont break back compat see this old ::API > https://github.com/bulk88/perl5-win32- > api/blob/067439edfd8fab5bc7f18f5bfb16fe7ff7a75259 > /API.xs#L324

more todo: get public opinions for putting a "scalar(@_) >= 3 && scalar(@_) <= 6" sanity check on ctor new(). Reason: http://perlmonks.org/?node_id=1019723 .

Sat Jun 29 14:02:44 2013 BULKDD [...] cpan.org - Correspondence added

All issues mentioned in this ticket were implemented or fixed in some (01 or 02) 0.76 alpha.

Sat Jun 29 14:02:44 2013 BULKDD [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Jun 29 14:02:45 2013 BULKDD [...] cpan.org - Fixed in 0.76_02 added