Skip Menu |

This queue is for tickets about the Quota CPAN distribution.

Report information
The Basics
Id: 82564
Status: resolved
Priority: 0/
Queue: Quota
People
Owner: tomzo [...] users.sourceforge.net
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.6.7
Fixed in: 1.7.1

History Show all quoted text
  Tue Jan 08 11:38:17 2013 CHORNY [...] cpan.org - Ticket created
Subject: test.pl asks invisible questions
CPAN::Reporter: make result is 'pass', No errors. TOMZO/Quota-1.6.7.tar.gz /usr/bin/make -- OK Running make test PERL_DL_NONLAZY=1 /home/c/perl5/perlbrew/perls/perl-5.16.2/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl (waits for input here) Quota::query(/dev/mapper/deb1-root): No quota for this user (waits for input here, but pressing "enter" many times does not help) -- Alexandr Ciornii, http://chorny.net
  Sat Aug 17 10:10:47 2013 tomzo [...] users.sourceforge.net - Correspondence added
Sorry for the long response time. I never saw an email notification for this ticket. The Quota module's "make test" does not support automated testing (because there's no portable way to verify the results). Therefore the "test.pl" immediately terminates when it finds that STDIN is not a terminal. Apparently this check is not sufficient in your case, where STDIN is a terminal (or at least perl's "-t" operator reports it as such) but STDOUT isn't sent to the same terminal (note the test script uses plain perl "print" to write its output). So, please specify exactly which environment you're running "make test" in, so that I can adapt the "if (! -t)" condition at the top of test.pl to terminate immediately. Best Regards
  Sat Aug 17 10:10:47 2013 The RT System itself - Status changed from 'new' to 'open'
  Sat Aug 17 11:40:05 2013 CHORNY [...] cpan.org - Correspondence added
On Sat Aug 17 10:10:47 2013, TOMZO wrote: Show quoted text
> Sorry for the long response time. I never saw an email notification > for this ticket. > > The Quota module's "make test" does not support automated testing > (because there's no portable way to verify the results). Therefore the > "test.pl" immediately terminates when it finds that STDIN is not a > terminal. Apparently this check is not sufficient in your case, where > STDIN is a terminal (or at least perl's "-t" operator reports it as > such) but STDOUT isn't sent to the same terminal (note the test script > uses plain perl "print" to write its output). > > So, please specify exactly which environment you're running "make > test" in, so that I can adapt the "if (! -t)" condition at the top of > test.pl to terminate immediately.
IMHO, it should check for ! -t || !-t STDOUT -- Alexandr Ciornii, http://chorny.net
  Tue Oct 01 12:33:21 2013 tomzo [...] users.sourceforge.net - Correspondence added
Fixed as previously suggested in release 1.7.1 of the Quota module: "make test" (i.e. test.pl) now exits immediately with an error message when either STDIN or STDOUT is not connected to a terminal device.
  Tue Oct 01 12:33:21 2013 tomzo [...] users.sourceforge.net - Status changed from 'open' to 'resolved'
  Tue Oct 01 12:33:21 2013 tomzo [...] users.sourceforge.net - Taken
  Tue Oct 01 12:33:22 2013 tomzo [...] users.sourceforge.net - Fixed in 1.7.1 added