Bug #82556 for Net-OAuth2: client->authorize_url should return the url + parameters

Tue Jan 08 02:05:01 2013 shmuelfomberg [...] gmail.com - Ticket created

Subject:

client->authorize_url should return the url + parameters

I think that client->authorize_url() should return the URL + parameters, as it does in Net::OAuth and also as it implied from the demo. where you wrote "redirect client(params->{site_id})->authorize_url" I may understand wrong, but looks to me that it won't work. Thanks, Shmuel.

Tue Jan 08 03:07:35 2013 solutions [...] overmeer.net - Correspondence added

Subject:	Re: [rt.cpan.org #82556] client->authorize_url should return the url + parameters
Date:	Tue, 8 Jan 2013 09:07:06 +0100
To:	Shmuel Fomberg via RT <bug-Net-OAuth2 [...] rt.cpan.org>
From:	Mark Overmeer <solutions [...] overmeer.net>

* Shmuel Fomberg via RT (bug-Net-OAuth2@rt.cpan.org) [130108 07:05]: Show quoted text

> Tue Jan 08 02:05:01 2013: Request 82556 was acted upon. > Transaction: Ticket created by SEMUELF > Queue: Net-OAuth2 > Subject: client->authorize_url should return the url + parameters > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82556 > > > > I think that client->authorize_url() should return the URL + parameters, > as it does in Net::OAuth and also as it implied from the demo. > where you wrote "redirect client(params->{site_id})->authorize_url" > I may understand wrong, but looks to me that it won't work.

This is a point I have changed, maybe not for the good. The issue is that "authorize_url" is an attribute to the object, which does not contain the parameters. So, basic OO rules are not met. Therfore, I renamed that feature to 'authorize'. I did not fix that in the example. Last night, I made a few more documentation fixes, which I will release later this morning. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net

Tue Jan 08 03:07:36 2013 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 08 03:32:51 2013 solutions [...] overmeer.net - Correspondence added

Subject:	Re: [rt.cpan.org #82556] client->authorize_url should return the url + parameters
Date:	Tue, 8 Jan 2013 09:32:40 +0100
To:	Shmuel Fomberg via RT <bug-Net-OAuth2 [...] rt.cpan.org>
From:	Mark Overmeer <solutions [...] overmeer.net>

* MARKOV Solutions (solutions@overmeer.net) [130108 09:07]: Show quoted text

> * Shmuel Fomberg via RT (bug-Net-OAuth2@rt.cpan.org) [130108 07:05]:

> > Tue Jan 08 02:05:01 2013: Request 82556 was acted upon. > > Transaction: Ticket created by SEMUELF > > Queue: Net-OAuth2 > > Subject: client->authorize_url should return the url + parameters > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82556 > > > > > > > I think that client->authorize_url() should return the URL + parameters, > > as it does in Net::OAuth and also as it implied from the demo. > > where you wrote "redirect client(params->{site_id})->authorize_url" > > I may understand wrong, but looks to me that it won't work.

> > This is a point I have changed, maybe not for the good.

My authorize() shouldn't be in the module: it my attempt to mimic a browser to be able to get some kind of regression-test. I replace it. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net

Tue Jan 08 21:04:37 2013 shmuelfomberg [...] gmail.com - Correspondence added

thanks, it seen OK now.

Tue Jan 08 21:04:39 2013 shmuelfomberg [...] gmail.com - Status changed from 'open' to 'resolved'