Skip Menu |

This queue is for tickets about the Sys-Syslog CPAN distribution.

Report information
The Basics
Id: 82531
Status: resolved
Priority: 0/
Queue: Sys-Syslog

People
Owner: Nobody in particular
Requestors: alexander.berger [...] finnova.ch
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in:
  • 0.29
  • 0.30
  • 0.31
  • 0.32
Fixed in: 0.33



Subject: Invalid usage of function POSIX::_exit
The fix for CPAN-RT#55215(Sys::Syslog might call exit which triggers DESTROY) introduced in version 0.29 contains an invalid use of function POSIX::_exit on line 501. The function POSIX::_exit must be called with an exit status code as its sole argument. It cannot be called without any arguments. If it is called without status code like in version 0.29 (up to version 0.32) it will raise an error. Therefore that line has to be changed from "POSIX::_exit if defined $pid;" to "POSIX::_exit(0) if defined $pid;"
Subject: Re: [rt.cpan.org #82531] Invalid usage of function POSIX::_exit
Date: Mon, 7 Jan 2013 20:10:18 +0100
To: bug-Sys-Syslog [...] rt.cpan.org
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
Alexander Berger wrote via RT: Show quoted text
> The fix for CPAN-RT#55215(Sys::Syslog might call exit which triggers DESTROY) > introduced in version 0.29 contains an invalid use of function POSIX::_exit on > line 501. > > The function POSIX::_exit must be called with an exit status code as its sole > argument. It cannot be called without any arguments. If it is called without > status code like in version 0.29 (up to version 0.32) it will raise an error. > Therefore that line has to be changed from > > "POSIX::_exit if defined $pid;" > > to > > "POSIX::_exit(0) if defined $pid;"
Well spotted. Thanks, applied. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.
From: alexander.berger [...] finnova.ch
I am sorry but now you introduced an error in line 522. You changed it to: POSIX::_exit(0) $ret if defined $pid; but you probably meant: POSIX::_exit($ret) if defined $pid; regards, Alex
Subject: Re: [rt.cpan.org #82531] Invalid usage of function POSIX::_exit
Date: Tue, 8 Jan 2013 08:13:58 +0100
To: bug-Sys-Syslog [...] rt.cpan.org
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
Alexander Berger wrote via RT: Show quoted text
> I am sorry but now you introduced an error in line 522. You changed it to: > > POSIX::_exit(0) $ret if defined $pid; > > but you probably meant: > > POSIX::_exit($ret) if defined $pid;
Ah right. Fixed. Thanks. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.