Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DBD-Oracle CPAN distribution.

Report information
The Basics
Id: 82506
Status: resolved
Priority: 0/
Queue: DBD-Oracle
People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.52
Fixed in: 1.56

History Show all quoted text
  Sat Jan 05 19:19:03 2013 ribasushi [...] leporine.io - Ticket created
Subject: New t/26exe_array.t fails to "skip itself"
After you added Test::NoWarnings::had_no_warnings under an END block, it is no longer possible to plan skip_all when no DSN to test is available. You need to add some flag so that the stuff in END doesn't fire, or just use POSIX::_exit to abort on the spot, since nothing has been done anyway. Test Summary Report ------------------- t/26exe_array.t (Wstat: 0 Tests: 1 Failed: 1) Failed test: 1 Parse errors: Bad plan. You planned 0 tests but ran 1. Files=37, Tests=10, 3 wallclock secs ( 0.12 usr 0.04 sys + 2.30 cusr 0.20 csys = 2.66 CPU) Result: FAIL Failed 1/37 test programs. 1/10 subtests failed.
  Sun Jan 06 05:10:40 2013 bohica [...] ntlworld.com - Correspondence added
On Sat Jan 05 19:19:03 2013, RIBASUSHI wrote: Show quoted text
> After you added Test::NoWarnings::had_no_warnings under an END block, it > is no longer possible to plan skip_all when no DSN to test is available. > You need to add some flag so that the stuff in END doesn't fire, or just > use POSIX::_exit to abort on the spot, since nothing has been done anyway. > > Test Summary Report > ------------------- > t/26exe_array.t (Wstat: 0 Tests: 1 Failed: 1) > Failed test: 1 > Parse errors: Bad plan. You planned 0 tests but ran 1. > Files=37, Tests=10, 3 wallclock secs ( 0.12 usr 0.04 sys + 2.30 cusr > 0.20 csys = 2.66 CPU) > Result: FAIL > Failed 1/37 test programs. 1/10 subtests failed.
Oops, sorry Peter. I'll fix. Thanks for the report. I need to keep reminding myself to test without a valid oracle. Martin -- Martin J. Evans Wetherby, UK
  Sun Jan 06 05:10:41 2013 The RT System itself - Status changed from 'new' to 'open'
  Mon Jan 07 13:13:05 2013 champoux [...] pythian.com - Correspondence added
Subject: Re: [rt.cpan.org #82506] New t/26exe_array.t fails to "skip itself"
Date: Mon, 07 Jan 2013 13:12:51 -0500
To: bug-DBD-Oracle [...] rt.cpan.org
From: Yanick Champoux <champoux [...] pythian.com>
On 13-01-06 05:10 AM, Martin J Evans via RT wrote: Show quoted text
> Oops, sorry Peter. I'll fix. Thanks for the report. I need to keep > reminding myself to test without a valid oracle.
I've pushed a fixed version to the repos. I might bundle a release sooner than usual to push the fix out there. Joy, `/anick -- --
  Tue Jan 08 12:26:13 2013 jcrotty_alpine [...] hotmail.com - Correspondence added
On Mon Jan 07 13:13:05 2013, PYTHIAN wrote: Show quoted text
> On 13-01-06 05:10 AM, Martin J Evans via RT wrote:
> > Oops, sorry Peter. I'll fix. Thanks for the report. I need to keep > > reminding myself to test without a valid oracle.
> > I've pushed a fixed version to the repos. I might bundle a release > sooner than usual to push the fix out there. > > Joy, > `/anick >
Sooner the better on this one. We are in the processing of moving to having the DEMO schema available, but won't for a few days probably so this is a bit of a show stopper for us. But a good lesson on getting DEMO setup!
  Tue Jan 08 12:48:08 2013 champoux [...] pythian.com - Correspondence added
Subject: Re: [rt.cpan.org #82506] New t/26exe_array.t fails to "skip itself"
Date: Tue, 08 Jan 2013 12:47:54 -0500
To: bug-DBD-Oracle [...] rt.cpan.org
From: Yanick Champoux <champoux [...] pythian.com>
On 13-01-08 12:26 PM, Joseph Crotty via RT wrote: Show quoted text
> Sooner the better on this one
Done. :-) Should appears on a mirror near you really soon... Joy, `/anick -- Yanick Champoux, Senior Perl Developer The Pythian Group - love your data http://www.pythian.com -- --
  Tue Jan 08 17:57:28 2013 bohica [...] ntlworld.com - Correspondence added
On Tue Jan 08 12:26:13 2013, holybit wrote: Show quoted text
> On Mon Jan 07 13:13:05 2013, PYTHIAN wrote:
> > On 13-01-06 05:10 AM, Martin J Evans via RT wrote:
> > > Oops, sorry Peter. I'll fix. Thanks for the report. I need to keep > > > reminding myself to test without a valid oracle.
> > > > I've pushed a fixed version to the repos. I might bundle a
> release
> > sooner than usual to push the fix out there. > > > > Joy, > > `/anick > >
> > Sooner the better on this one. We are in the processing of moving to > having the DEMO > schema available, but won't for a few days probably so this is a bit > of a show stopper for us. > But a good lesson on getting DEMO setup! > >
Just for my clarification just how is this RT a show stopper? All it means is if you don't have an Oracle to test against a test fails. You can still install it. Perhaps I'm missing something and you can enlighten me. Martin -- Martin J. Evans Wetherby, UK
  Tue Jan 08 19:03:10 2013 champoux [...] pythian.com - Correspondence added
Subject: Re: [rt.cpan.org #82506] New t/26exe_array.t fails to "skip itself"
Date: Tue, 08 Jan 2013 19:02:25 -0500
To: bug-DBD-Oracle [...] rt.cpan.org
From: Yanick Champoux <champoux [...] pythian.com>
On 13-01-08 05:57 PM, Martin J Evans via RT wrote: Show quoted text
> Perhaps I'm missing something and you can > enlighten me.
Sure: User wants to install App::Cromulent. Goes and do 'cpanm App::Cromulent'. cpanm does its magic and pull the 63 dependencies App::Cromulent has. Something somewhere fails. User has to dig in the logs and figure out that (a) it's DBD::Oracle that is failing and (b) that the fail is something that be safely ignored. User swears, and has now to install DBD::Oracle by itself, making sure to bypass tests, and then return to installing App::Cromulent and the rest of its dependencies. People can still install modules if they fail, but it breaks automated chains and cost time. The default path should never be failure. Plus, the fact that it was an easy fix really didn't leave any excuse not to patch it ASAP. :-) Joy, `/anick -- --
  Sat Jan 12 12:22:53 2013 bohica [...] ntlworld.com - Status changed from 'open' to 'patched'
  Sat Jan 12 12:29:26 2013 bohica [...] ntlworld.com - Status changed from 'patched' to 'resolved'
  Sat Jan 12 12:29:27 2013 bohica [...] ntlworld.com - Fixed in 1.56 added