Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Net-GitHub CPAN distribution.

Report information
The Basics
Id: 82391
Status: resolved
Priority: 0/
Queue: Net-GitHub

People
Owner: Nobody in particular
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.50
Fixed in: (no value)



Subject: Allow configuration of WWW::Mechanize + share the mech object.
I've hit a bug with keep_alive + https in LWP which effects Net::GitHub.  See https://rt.cpan.org/Ticket/Display.html?id=82375

The Net::GitHub configuration looks sensible, and the bug transient, so it would be nice if a user could control the creation of the user agent.  It's a little hard to control as that right now as its in a role, but I can probably make it work.

Additionally, right now each object gets its own mech object.  That seems wasteful.  I'd like to change it so, by default, they all share the same mech object.

What do you think about that?
Yes. I agree with those points. and patches are welcome. Thanks On Thu Jan 03 19:29:30 2013, MSCHWERN wrote: Show quoted text
> I've hit a bug with keep_alive + https in LWP which effects > Net::GitHub. See > https://rt.cpan.org/Ticket/Display.html?id=82375 > > The Net::GitHub configuration looks sensible, and the bug transient, > so it > would be nice if a user could control the creation of the user agent. > It's a > little hard to control as that right now as its in a role, but I can > probably > make it work. > > Additionally, right now each object gets its own mech object. That > seems > wasteful. I'd like to change it so, by default, they all share the > same mech > object. > > What do you think about that?
now all the ua are passed to each sub modules. so you can do my $gh = Net::GitHub->new( ua => WWW::Mechanize->new(...) ); and following $gh->search or $gh->... will share this ua. let me know if that's not what you need. Thanks