Skip Menu |

This queue is for tickets about the Config-Perl-V CPAN distribution.

Report information
The Basics
Id: 82386
Status: resolved
Priority: 0/
Queue: Config-Perl-V
People
Owner: Nobody in particular
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: 0.15
Fixed in: 0.19

History Show all quoted text
  Thu Jan 03 14:54:36 2013 CHORNY [...] cpan.org - Ticket created
Subject: [patch] use TEST_REQUIRES
Please pull from https://github.com/chorny/Config-Perl-V . It adds using TEST_REQUIRES for Makefile.PL, so Test::NoWarnings can be used without installing it. -- Alexandr Ciornii, http://chorny.net
  Thu Jan 03 15:06:46 2013 CHORNY [...] cpan.org - Severity Normal changed to Wishlist
  Thu Jan 03 15:50:32 2013 h.m.brand [...] xs4all.nl - Correspondence added
CC: h.m.brand [...] xs4all.nl
Subject: Re: [rt.cpan.org #82386] [patch] use TEST_REQUIRES
Date: Thu, 3 Jan 2013 21:50:17 +0100
To: bug-Config-Perl-V [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
Show quoted text
> Thu Jan 03 14:54:36 2013: Request 82386 was acted upon. > Please pull from https://github.com/chorny/Config-Perl-V . > It adds using TEST_REQUIRES for Makefile.PL, so Test::NoWarnings > can be used without installing it.
I will consider the change, but for sure not in the form presented, as it does not follow my style and layout, so a pull is out of the question. Next to that, I create the META stuff in sandbox/genMETA.pl (which expects a change in sandbox/genMETA.pm in which I fixed compatibility issues
  Thu Jan 03 15:50:34 2013 The RT System itself - Status changed from 'new' to 'open'
  Sun Feb 17 05:35:19 2013 HMBRAND [...] cpan.org - Correspondence added
Thanks for catching the typo in genMETA.pl I don't think your approach in "fixing" other author's Makefile.PL's is a viable one. Your patch(es) ruin the style people use, and also add cruft that isn't used at all in the files patched. If you want this road to be a success, only patch what is used and try *very hard* to follow the style of the author and don't force ugly code on us. I have just pushed a very simplified (and WAY better styled) "fix" to the wish you had. Feel free to pull and try.
  Sun Feb 17 05:35:20 2013 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'
  Sun Feb 17 20:28:41 2013 CHORNY [...] cpan.org - Correspondence added
On Sun Feb 17 05:35:19 2013, HMBRAND wrote: Show quoted text
> I have just pushed a very simplified (and WAY better styled) "fix" to > the wish you had. Feel free to pull and try.
Yes, it works. IMHO, as latest EU::MM is not widespread yet, using BUILD_REQUIRES would be more useful: my $section = $eummv > 6.54 ? "BUILD_REQUIRES" : "PREREQ_PM"; -- Alexandr Ciornii, http://chorny.net
  Sun Feb 17 20:28:41 2013 The RT System itself - Status changed from 'patched' to 'open'
  Tue Jul 02 15:52:49 2013 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'
  Thu Aug 29 03:06:40 2013 HMBRAND [...] cpan.org - Fixed in 0.19 added
  Thu Aug 29 03:06:40 2013 HMBRAND [...] cpan.org - Status changed from 'patched' to 'resolved'