Bug #82052 for Socket: Wrong format specifier causes two warnings

Mon Dec 17 11:39:03 2012 vpit [...] cpan.org - Ticket created

Subject:

Wrong format specifier causes two warnings

This is with clang on darwin, but most likely also happens with gcc -Wformat. Socket.xs:919:16: warning: format specifies type 'int' but the argument has type 'STRLEN' (aka 'unsigned long') [-Wformat] " got %d, should be 4", addrlen); ~^ ~~~~~~~ %ld Socket.xs:925:16: warning: format specifies type 'int' but the argument has type 'STRLEN' (aka 'unsigned long') [-Wformat] " got %d, should be 16", addrlen); ~^ ~~~~~~~ %ld There is a similar piece of code in inet_ntoa() from which you can steal to silence these warnings. Vincent

Subject:

warn.txt

Socket.xs:919:16: warning: format specifies type 'int' but the argument has type 'STRLEN' (aka 'unsigned long') [-Wformat] " got %d, should be 4", addrlen); ~^ ~~~~~~~ %ld Socket.xs:925:16: warning: format specifies type 'int' but the argument has type 'STRLEN' (aka 'unsigned long') [-Wformat] " got %d, should be 16", addrlen); ~^ ~~~~~~~ %ld

Mon Dec 17 17:49:46 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Mon Dec 17 11:39:03 2012, VPIT wrote: Show quoted text

> This is with clang on darwin, but most likely also happens with gcc > -Wformat. > > Socket.xs:919:16: warning: format specifies type 'int' but the argument > has type 'STRLEN' (aka 'unsigned long') [-Wformat] > " got %d, should be 4", addrlen);

Oops, classic mistake. Show quoted text

> There is a similar piece of code in inet_ntoa() from which you can steal > to silence these warnings.

Ahyes, will do. -- Paul Evans

Mon Dec 17 17:49:47 2012 The RT System itself - Status changed from 'new' to 'open'

Mon Dec 17 17:53:02 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Patched; will be in next release. -- Paul Evans

Subject:

rt82052.patch

=== modified file 'Socket.xs' --- Socket.xs 2012-12-16 18:22:50 +0000 +++ Socket.xs 2012-12-17 22:52:32 +0000 @@ -916,13 +916,13 @@ case AF_INET: if(addrlen != 4) croak("Bad address length for Socket::inet_ntop on AF_INET;" - " got %d, should be 4", addrlen); + " got %"UVuf", should be 4", (UV)addrlen); break; #ifdef AF_INET6 case AF_INET6: if(addrlen != 16) croak("Bad address length for Socket::inet_ntop on AF_INET6;" - " got %d, should be 16", addrlen); + " got %"UVuf", should be 16", (UV)addrlen); break; #endif default:

Mon Dec 17 17:53:03 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Sun Jan 06 20:45:52 2013 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Sun Jan 06 20:45:53 2013 leonerd-cpan [...] leonerd.org.uk - Fixed in 2.008 added