Bug #82017 for File-Map: [Win32] 0.52 is the last version to successfully build on perl-5.8.8

Sun Dec 16 06:05:04 2012 sisyphus [...] cpan.org - Ticket created

Subject:

[Win32] 0.52 is the last version to successfully build on perl-5.8.8

Hi, Please feel free to regard this as an FYI - and not something that needs to be addressed immediately. The Map.xs from File-Map-0.53 (and later) assumes that STR_WITH_LEN has been defined - which is correct for perl-5.8.9 and later (defined in handy.h), but not perl-5.8.8 and earlier. This is easily fixed by placing the definition of STR_WITH_LEN in Map.xs - and File-Map-0.55 then builds fine on perl 5.8.8, except that t/20-threads.t crashes during 'Build test'. (No other test scripts fail.) I don't know what's required to fix this crashing. It looks that there were quite a few changes between 5.8.8 and 5.8.9 wrt threads. (These Win32 perls are, of course, multi-threaded.) Btw, File-Map-0.55 builds and tests fine for perl-5.8.9 and later. Cheers, Rob

Sun Dec 16 18:39:00 2012 sisyphus [...] cpan.org - Correspondence added

On Sun Dec 16 06:05:04 2012, SISYPHUS wrote: Show quoted text

> t/20-threads.t crashes during 'Build test'.

If I remove the -T switch, the problem vanishes and all tests pass. Reinstating the -T switch, if I run 'perl -T -Mblib t/20-threads.t' I get: ########################## Insecure dependency in require while running with -T switch at t/20-threads.t line 5. BEGIN failed--compilation aborted at t/20-threads.t line 5. ########################## So ... now I'm not sure whether the problem is with the -T switch, or the threading, or both. Running that same command on 5.8.9, produces the same error, but reports different line numbers in t/20-threads.t: ########################## Insecure dependency in require while running with -T switch at t/20-threads.t line 9. BEGIN failed--compilation aborted at t/20-threads.t line 18. ########################## What's the correct way of running 'perl -Mblib t/20-threads.t' ? At least, on 5.8.9 and later, 'Build test' runs successfully. Cheers, Rob

Sun Dec 16 18:39:01 2012 sisyphus [...] cpan.org - Status changed from 'new' to 'open'

Sun Dec 16 18:49:12 2012 fawaka [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #82017] [Win32] 0.52 is the last version to successfully build on perl-5.8.8
Date:	Mon, 17 Dec 2012 00:48:38 +0100
To:	bug-File-Map [...] rt.cpan.org
From:	Leon Timmermans <fawaka [...] gmail.com>

On Sun, Dec 16, 2012 at 12:05 PM, Sisyphus via RT <bug-File-Map@rt.cpan.org> wrote: Show quoted text

> The Map.xs from File-Map-0.53 (and later) assumes that STR_WITH_LEN has > been defined - which is correct for perl-5.8.9 and later (defined in > handy.h), but not perl-5.8.8 and earlier. > This is easily fixed by placing the definition of STR_WITH_LEN in Map.xs > - and File-Map-0.55 then builds fine on perl 5.8.8,

Seems I forgot to include the ppport.h file. That should be easy to fix. Leon

Sun Dec 16 19:36:18 2012 LEONT [...] cpan.org - Correspondence added

On Sun Dec 16 18:39:00 2012, SISYPHUS wrote: Show quoted text

> On Sun Dec 16 06:05:04 2012, SISYPHUS wrote: >

> > t/20-threads.t crashes during 'Build test'.

> > If I remove the -T switch, the problem vanishes and all tests pass. > > Reinstating the -T switch, if I run 'perl -T -Mblib t/20-threads.t' I get: > > ########################## > Insecure dependency in require while running with -T switch at > t/20-threads.t line 5. > BEGIN failed--compilation aborted at t/20-threads.t line 5. > ########################## > > So ... now I'm not sure whether the problem is with the -T switch, or > the threading, or both. > > Running that same command on 5.8.9, produces the same error, but reports > different line numbers in t/20-threads.t: > > ########################## > Insecure dependency in require while running with -T switch at > t/20-threads.t line 9. > BEGIN failed--compilation aborted at t/20-threads.t line 18. > ########################## > > What's the correct way of running 'perl -Mblib t/20-threads.t' ? > > At least, on 5.8.9 and later, 'Build test' runs successfully.

Sounds like getting rid of the tainting mode is the way to go. It got there more through cargo-culting than through deliberate design. Leon

Sat May 25 18:36:13 2013 LEONT [...] cpan.org - Correspondence added

On Sun Dec 16 06:05:04 2012, SISYPHUS wrote: Show quoted text

> Hi, > > Please feel free to regard this as an FYI - and not something that needs > to be addressed immediately. > > The Map.xs from File-Map-0.53 (and later) assumes that STR_WITH_LEN has > been defined - which is correct for perl-5.8.9 and later (defined in > handy.h), but not perl-5.8.8 and earlier. > This is easily fixed by placing the definition of STR_WITH_LEN in Map.xs > - and File-Map-0.55 then builds fine on perl 5.8.8, except that > t/20-threads.t crashes during 'Build test'. (No other test scripts fail.) > > I don't know what's required to fix this crashing. It looks that there > were quite a few changes between 5.8.8 and 5.8.9 wrt threads. > (These Win32 perls are, of course, multi-threaded.) > > Btw, File-Map-0.55 builds and tests fine for perl-5.8.9 and later.

I think this is resolved, but I'm lacking a CPAN Testers result, can you confirmation? Leon

Sat May 25 22:53:51 2013 sisyphus1 [...] optusnet.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #82017] [Win32] 0.52 is the last version to successfully build on perl-5.8.8
Date:	Sun, 26 May 2013 12:52:34 +1000
To:	<bug-File-Map [...] rt.cpan.org>, <sisyphus [...] cpan.org>
From:	<sisyphus1 [...] optusnet.com.au>

Show quoted text

-----Original Message----- From: Leon Timmermans via RT

> I think this is resolved, but I'm lacking a CPAN Testers result, can you > confirmation?

Yes - no problems with 0.57 on 5.8.8 (or later). Thanks, Leon. Cheers, Rob

Sun May 26 09:00:16 2013 LEONT [...] cpan.org - Status changed from 'open' to 'resolved'