Skip Menu |

This queue is for tickets about the Crypt-Twofish CPAN distribution.

Report information
The Basics
Id: 82012
Status: resolved
Priority: 0/
Queue: Crypt-Twofish

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.15
Fixed in: 2.17



Subject: Bleadperl v5.17.6-328-g463ea22 breaks Twofish.xs
As per subject. Here is the commit: http://perl5.git.perl.org/perl.git/commit/463ea2290a54ee65470ca4dd46dea0d41cfbc9dd Tested patch: --- Twofish.xs~ 2001-05-21 19:38:01.000000000 +0200 +++ Twofish.xs 2012-12-16 08:07:17.980425700 +0100 @@ -54,7 +54,8 @@ output = sv_newmortal(); outlen = 16; - if (SvREADONLY(output) || !SvUPGRADE(output, SVt_PV)) + SvUPGRADE(output, SVt_PV); + if (SvREADONLY(output)) croak("cannot use output as lvalue"); twofish_crypt(self, HTH,
I believe that this was fixed in v2.17 and that this ticket can be closed. -- rjbs
Resolved as per Rick's suggestion. Thanks!