On Sat Dec 15 19:55:42 2012, SPROUT wrote:
Show quoted text> Please be advised that Socket.xs has been modified to fix this in the
> perl core. The commit ID is
> 5d6dfea82e1c4b6.
>
> CPAN is listed as upstream for Socket, which is why I am filing this
> ticket. (It would be
> unfortunate for the next upgrade in the perl core to undo the fix.)
Ah thanks. Will do so.
[attached is the patch, for posterity]
--
Paul Evans
diff --git a/cpan/Socket/Socket.pm b/cpan/Socket/Socket.pm
index c0dc4aa..a3a38d9 100644 (file)
--- a/cpan/Socket/Socket.pm
+++ b/cpan/Socket/Socket.pm
@@ -3,7 +3,7 @@ package Socket;
use strict;
{ use 5.006001; }
-our $VERSION = '2.006';
+our $VERSION = '2.006_001';
=head1 NAME
diff --git a/cpan/Socket/Socket.xs b/cpan/Socket/Socket.xs
index e99eac1..4bfaada 100644 (file)
--- a/cpan/Socket/Socket.xs
+++ b/cpan/Socket/Socket.xs
@@ -916,13 +916,13 @@ inet_ntop(af, ip_address_sv)
case AF_INET:
if(addrlen != 4)
croak("Bad address length for Socket::inet_ntop on AF_INET;"
- " got %d, should be 4");
+ " got %d, should be 4", addrlen);
break;
#ifdef AF_INET6
case AF_INET6:
if(addrlen != 16)
croak("Bad address length for Socket::inet_ntop on AF_INET6;"
- " got %d, should be 16");
+ " got %d, should be 16", addrlen);
break;
#endif
default:
