Skip Menu |

This queue is for tickets about the File-Map CPAN distribution.

Report information
The Basics
Id: 81975
Status: rejected
Priority: 0/
Queue: File-Map

People
Owner: Nobody in particular
Requestors: jv [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.54
Fixed in: (no value)



Attached patch eliminates the unneccessary dependency on Sub::Exporter::Progressive.
Subject: File-Map-0.54-Exporter.patch
*** lib/File/Map.pm~ 2012-12-13 23:48:02.000000000 +0100 --- lib/File/Map.pm 2012-12-14 10:15:37.000000000 +0100 *************** *** 13,25 **** use warnings FATAL => 'all'; use subs qw{PROT_READ PROT_WRITE MAP_PRIVATE MAP_SHARED MAP_FILE MAP_ANONYMOUS}; ! use Sub::Exporter::Progressive 0.001005 (); use XSLoader (); use Carp qw/croak carp/; use PerlIO::Layers qw/query_handle/; XSLoader::load('File::Map', File::Map->VERSION); my %export_data = ( 'map' => [qw/map_handle map_file map_anonymous unmap sys_map/], extra => [qw/remap sync pin unpin advise protect/], --- 13,28 ---- use warnings FATAL => 'all'; use subs qw{PROT_READ PROT_WRITE MAP_PRIVATE MAP_SHARED MAP_FILE MAP_ANONYMOUS}; ! use base qw(Exporter); use XSLoader (); use Carp qw/croak carp/; use PerlIO::Layers qw/query_handle/; XSLoader::load('File::Map', File::Map->VERSION); + our %EXPORT_TAGS; + our @EXPORT_OK; + my %export_data = ( 'map' => [qw/map_handle map_file map_anonymous unmap sys_map/], extra => [qw/remap sync pin unpin advise protect/], *************** *** 32,43 **** while (my ($category, $functions) = each %export_data) { for my $function (grep { defined &{$_} } @{$functions}) { ! push @export_ok, $function; ! push @{ $export_tags{$category} }, $function; } } - - Sub::Exporter::Progressive->import(-setup => { exports => \@export_ok, groups => \%export_tags }); } my $anon_fh = -1; --- 35,44 ---- while (my ($category, $functions) = each %export_data) { for my $function (grep { defined &{$_} } @{$functions}) { ! push @EXPORT_OK, $function; ! push @{ $EXPORT_TAGS{$category} }, $function; } } } my $anon_fh = -1; *************** *** 401,407 **** =head1 DEPENDENCIES ! This module depends on perl 5.8, L<Const::Fast> and L<PerlIO::Layers>. Perl 5.8.8 or higher is recommended because older versions can give spurious warnings. On perl versions before 5.11.5 many string functions including C<substr> are limited to L<32bit logic|http://rt.perl.org/rt3//Public/Bug/Display.html?id=72784>, even on 64bit architectures. Effectively this means you can't use them on strings bigger than 2GB. If you are working with such large files, it is strongly recommended to upgrade to 5.12. --- 402,408 ---- =head1 DEPENDENCIES ! This module depends on perl 5.8 and L<PerlIO::Layers>. Perl 5.8.8 or higher is recommended because older versions can give spurious warnings. On perl versions before 5.11.5 many string functions including C<substr> are limited to L<32bit logic|http://rt.perl.org/rt3//Public/Bug/Display.html?id=72784>, even on 64bit architectures. Effectively this means you can't use them on strings bigger than 2GB. If you are working with such large files, it is strongly recommended to upgrade to 5.12.
On Fri Dec 14 04:18:36 2012, JV wrote: Show quoted text
> Attached patch eliminates the unneccessary dependency on > Sub::Exporter::Progressive.
I'm sure it's not everyone's thing, but I quite like having the extra possibilities it provides. I'm going to have to reject this one. Leon