Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Catalyst-TraitFor-Controller-DBIC-DoesPaging CPAN distribution.

Report information
The Basics
Id: 81956
Status: resolved
Priority: 0/
Queue: Catalyst-TraitFor-Controller-DBIC-DoesPaging
People
Owner: Nobody in particular
Requestors: danielb [...] libentech.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Dec 13 22:47:45 2012 danielb [...] libentech.com - Ticket created
Subject: Patch to Decouple From Catalyst
Date: Thu, 13 Dec 2012 21:47:33 -0600
To: bug-Catalyst-TraitFor-Controller-DBIC-DoesPaging [...] rt.cpan.org
From: Daniel Baber <danielb [...] libentech.com>
Hello I was wondering if you'd be willing to take a patch that would couple this module less tightly to catalyst. Instead of accepting $c as the first argument to everything could we instead take a hash of params (with catalyst you can usually just pass in $c->req->params) so it would be possible to do validation of these parameters with something like FormValidator before applying all the paging, searching, and sorting goodness. I have attached a patch doing just that. It also updates the POD docs in the module as well and some of the test code so all the current tests pass. Thanks, Dan -- "I sincerely believe ... that banking establishments are more dangerous than standing armies, and that the principle of spending money to be paid by posterity, under the name of funding, is but swindling futurity on a large scale." -- Thomas Jefferson in a letter to John Taylor May 28, 1816 Support The Campaign For Liberty - http://www.campaignforliberty.com, Sign up Now!

Message body is not shown because sender requested not to inline it.

  Mon Dec 17 17:27:45 2012 danielb [...] libentech.com - Correspondence added
Subject: Re: [rt.cpan.org #81956] AutoReply: Patch to Decouple From Catalyst
Date: Mon, 17 Dec 2012 16:27:33 -0600
To: bug-Catalyst-TraitFor-Controller-DBIC-DoesPaging [...] rt.cpan.org
From: Daniel Baber <danielb [...] libentech.com>
I have revised the patch to not break the current interface and allow either a context object or a hashref passed into the methods as the first argument. Dan On Thu, Dec 13, 2012 at 9:47 PM, Bugs in Catalyst-TraitFor-Controller-DBIC-DoesPaging via RT < bug-Catalyst-TraitFor-Controller-DBIC-DoesPaging@rt.cpan.org> wrote: Show quoted text
> > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "Patch to Decouple From Catalyst", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #81956]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=81956 > > Please include the string: > > [rt.cpan.org #81956] > > in the subject line of all future correspondence about this issue. To do > so, > you may reply to this message. > > Thank you, > > bug-Catalyst-TraitFor-Controller-DBIC-DoesPaging@rt.cpan.org > > ------------------------------------------------------------------------- > Hello I was wondering if you'd be willing to take a patch that would couple > this module less tightly to catalyst. Instead of accepting $c as the first > argument to everything could we instead take a hash of params (with > catalyst you can usually just pass in $c->req->params) so it would be > possible to do validation of these parameters with something like > FormValidator before applying all the paging, searching, and sorting > goodness. > > I have attached a patch doing just that. It also updates the POD docs in > the module as well and some of the test code so all the current tests pass. > > Thanks, > Dan > > -- > "I sincerely believe ... that banking establishments are more dangerous > than standing armies, and that the principle of spending money to be paid > by posterity, under the name of funding, is but swindling futurity on a > large scale." > -- Thomas Jefferson in a letter to John Taylor May 28, 1816 > > Support The Campaign For Liberty - http://www.campaignforliberty.com, Sign > up Now! > >
-- "I sincerely believe ... that banking establishments are more dangerous than standing armies, and that the principle of spending money to be paid by posterity, under the name of funding, is but swindling futurity on a large scale." -- Thomas Jefferson in a letter to John Taylor May 28, 1816 Support The Campaign For Liberty - http://www.campaignforliberty.com, Sign up Now!

Message body is not shown because sender requested not to inline it.

  Sun May 26 03:02:24 2013 frioux [...] gmail.com - Correspondence added
Sorry for the radio silence on this. I'll have something related released shortly. I actually decided to go a simpler route and create a module that just has subroutines, not even methods, that can support hashes. I'll be sure to post here again before I release it to make sure it can handle your use case.
  Sun May 26 03:02:25 2013 The RT System itself - Status changed from 'new' to 'open'
  Tue Jun 11 11:50:49 2013 frioux [...] gmail.com - Correspondence added
On Sun May 26 03:02:24 2013, frew wrote: Show quoted text
> Sorry for the radio silence on this. I'll have something related > released shortly. I actually decided to go a simpler route and > create a module that just has subroutines, not even methods, that > can support hashes. I'll be sure to post here again before I > release it to make sure it can handle your use case.
Fixed with the release of Web::Util::DBIC::Paging
  Tue Jun 11 11:50:50 2013 frioux [...] gmail.com - Status changed from 'open' to 'resolved'