Skip Menu |

This queue is for tickets about the Params-Util CPAN distribution.

Report information
The Basics
Id: 81924
Status: resolved
Priority: 0/
Queue: Params-Util

People
Owner: Nobody in particular
Requestors: sferencik [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.07
Fixed in: (no value)



Subject: obsolete section in Makefile.PL?
Are perhaps lines 35 .. 53 of Makefile.PL obsolete now that the 1*.t test files are part of the source archive (tar.gz)? My installation procedure involves checking the sources into the VCS (Perforce), which makes them read-only. Then calling Makefile.PL fails when trying to write the 1*.t files (since they are read-only). Thanks, Sam
From: paul [...] liekut.de
Hi Sam, Show quoted text
> Are perhaps lines 35 .. 53 of Makefile.PL obsolete now that the 1*.t test > files are part of the source archive (tar.gz)?
I agree with you. Attached is a patch which removes the relevant code. Cheers, Paul
Subject: 0001-Not-generating-the-non-XS-tests-they-are-part-of-the.patch
From 7c9f5418f478bfb2d8244f02e45ca8288f1981ca Mon Sep 17 00:00:00 2001 From: Paul Cochrane <paul@liekut.de> Date: Thu, 29 May 2014 00:13:33 +0200 Subject: [PATCH] Not generating the non-XS tests; they are part of the distro --- Makefile.PL | 35 ----------------------------------- 1 file changed, 35 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 8731ae8..f6fa27f 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -20,45 +20,10 @@ if ( $^O eq 'cygwin' and $make_xs == 1 and not /^-xs/ ) { $make_xs = 0; } -# Generate the non-XS tests if we are making the XS version -my @tests = qw{ - t/01_compile.t - t/02_main.t - t/03_all.t - t/04_codelike.t - t/05_typelike.t - t/06_invocant.t - t/07_handle.t - t/08_driver.t - t/09_insideout.t -}; -if ( $make_xs ) { - foreach my $file ( @tests ) { - # Load the original - local *FILE; - local $/ = undef; - open( FILE, "<$file" ) or die("Failed to open '$file'"); - my $buffer = <FILE>; - close( FILE ) or die("Failed to close '$file'"); - - # Convert it to a pure perl version - $file =~ s/0/1/; - $buffer =~ s/0;/1;/; - - # Write the pure perl version - open( FILE, ">$file" ) or die("Failed to open '$file'"); - print FILE $buffer; - close( FILE ) or die("Failed to close '$file'"); - } -} - my @clean = ( # 'test.c', '*.old' ); -if ( $make_xs ) { - push @clean, @tests; -} WriteMakefile( # We created our own META.yml -- 1.7.10.4
From: Sam Ferencik
Hi Paul, Thanks, the patch looks good. (It's exactly how I patched it for myself in Dec 2012, and it's working.) Best regards, Sam
New tooling made the patch slightly obsolete, but should be fixed anyway ;)