Bug #81914 for Helios: Race condition on PID file

Tue Dec 11 20:43:20 2012 LAJANDY [...] cpan.org - Ticket created

Subject:

Race condition on PID file

Client had issue where two instances of a watch script ran at the same time and successfully started two Helios daemons for the same service on the same host.

Tue Dec 11 20:43:53 2012 LAJANDY [...] cpan.org - Taken

Tue Dec 11 20:47:09 2012 LAJANDY [...] cpan.org - Correspondence added

On Tue Dec 11 20:43:20 2012, LAJANDY wrote: Show quoted text

> Client had issue where two instances of a watch script ran at the same > time and successfully started two Helios daemons for the same service on > the same host.

The helios.pl daemon does not try to lock its PID file currently, so that is a (remote) possibility in a small number of circumstances. We should be able to fix this bug by exclusive flocking the pid file; it should only be a few extra lines of code in the write_pid_file() function in helios.pl.

Tue Dec 11 20:47:10 2012 LAJANDY [...] cpan.org - Status changed from 'new' to 'open'

Wed Dec 12 20:01:58 2012 LAJANDY [...] cpan.org - Correspondence added

A branch has been created on GitHub for this bug: https://github.com/logicalhelion/helios/tree/bug/rt81914

Sun Aug 04 16:26:09 2013 LAJANDY [...] cpan.org - Correspondence added

On Wed Dec 12 20:01:58 2012, LAJANDY wrote: Show quoted text

> A branch has been created on GitHub for this bug: > > https://github.com/logicalhelion/helios/tree/bug/rt81914 >

A potential fix for this bug has just been submitted to the GitHub branch above. Assuming it passes further testing, it will be rolled in with a forthcoming bugfix release.

Fri Sep 13 16:50:43 2013 LAJANDY [...] cpan.org - Correspondence added

On Sun Aug 04 16:26:09 2013, LAJANDY wrote: Show quoted text

> On Wed Dec 12 20:01:58 2012, LAJANDY wrote:

> > A branch has been created on GitHub for this bug: > > > > https://github.com/logicalhelion/helios/tree/bug/rt81914 > >

> > A potential fix for this bug has just been submitted to the GitHub > branch above. Assuming it passes further testing, it will be rolled > in with a forthcoming bugfix release.

Fri Sep 13 16:50:43 2013 LAJANDY [...] cpan.org - Status changed from 'open' to 'patched'

Fri Sep 13 16:50:43 2013 LAJANDY [...] cpan.org - Fixed in 2.601_3610 added

Fri Sep 13 16:50:43 2013 LAJANDY [...] cpan.org - Fixed in 2.601_3670 added

Sat Sep 14 18:49:44 2013 LAJANDY [...] cpan.org - Correspondence added

On Fri Sep 13 16:50:43 2013, LAJANDY wrote: Show quoted text

> On Sun Aug 04 16:26:09 2013, LAJANDY wrote:

> > On Wed Dec 12 20:01:58 2012, LAJANDY wrote:

> > > A branch has been created on GitHub for this bug: > > > > > > https://github.com/logicalhelion/helios/tree/bug/rt81914 > > >

> > > > A potential fix for this bug has just been submitted to the GitHub > > branch above. Assuming it passes further testing, it will be rolled > > in with a forthcoming bugfix release.

> >

Sat Sep 14 18:49:44 2013 LAJANDY [...] cpan.org - Fixed in 2.601_3750 added

Mon Sep 16 19:51:23 2013 LAJANDY [...] cpan.org - Correspondence added

On Sat Sep 14 18:49:44 2013, LAJANDY wrote: Show quoted text

> On Fri Sep 13 16:50:43 2013, LAJANDY wrote:

> > On Sun Aug 04 16:26:09 2013, LAJANDY wrote:

> > > On Wed Dec 12 20:01:58 2012, LAJANDY wrote:

> > > > A branch has been created on GitHub for this bug: > > > > > > > > https://github.com/logicalhelion/helios/tree/bug/rt81914 > > > >

> > > > > > A potential fix for this bug has just been submitted to the GitHub > > > branch above. Assuming it passes further testing, it will be rolled > > > in with a forthcoming bugfix release.

> > > >

> >

Mon Sep 16 19:51:24 2013 LAJANDY [...] cpan.org - Status changed from 'patched' to 'resolved'

Mon Sep 16 19:51:24 2013 LAJANDY [...] cpan.org - Fixed in 2.61 added