Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Smart-Options CPAN distribution.

Report information
The Basics
Id: 81870
Status: resolved
Priority: 0/
Queue: Smart-Options

People
Owner: kan.fushihara [...] gmail.com
Requestors: NGLENN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.021
Fixed in: (no value)



Subject: [PATCH] Fix failing tests on Windows
ウィンドウズにきれいにはインストールできませんでした。File::Specを使ったらプラットホームに存在する 必要がなくなります。 Patchを送っておきます。
Subject: 05_subcmd.t.diff
diff --git a/t/05_subcmd.t b/t/05_subcmd.t index f249ef0..be40dd7 100644 --- a/t/05_subcmd.t +++ b/t/05_subcmd.t @@ -3,6 +3,9 @@ use Test::More; use Smart::Options; +use File::Spec; +my $fileName = File::Spec->catfile('t','05_subcmd.t'); + subtest 'support subcommand' => sub { my $opt = Smart::Options->new(); $opt->subcmd(add => Smart::Options->new()->demand(qw(x y))); @@ -23,7 +26,7 @@ subtest 'subcommand usage' => sub { $opt->subcmd(minus => Smart::Options->new()->demand(qw(x y))); $opt->boolean('u'); is $opt->help, <<"EOS", 'subcmd help'; -Usage: t/05_subcmd.t [option] COMMAND +Usage: $fileName [option] COMMAND Options: -h, --help Show help
Subject: 10_help.t.diff
diff --git a/t/declare/10_help.t b/t/declare/10_help.t index a83da2e..8e5d881 100644 --- a/t/declare/10_help.t +++ b/t/declare/10_help.t @@ -5,6 +5,9 @@ use Test::More; use Try::Tiny; use Capture::Tiny ':all'; +use File::Spec; +my $fileName = File::Spec->catfile('t','declare','10_help.t'); + my $out = capture_stderr { try { @ARGV = qw(--help); @@ -12,8 +15,8 @@ my $out = capture_stderr { } }; -is $out, <<EOS, 'help message'; -Usage: t/declare/10_help.t +is $out, <<"EOS", 'help message'; +Usage: $fileName Options: -h, --help Show help
パッチありがとうございます。取り込んでリリースします
I shipped Smart-Options-0.03 merged your patch. thanks