Skip Menu |

This queue is for tickets about the SQL-Statement CPAN distribution.

Report information
The Basics
Id: 8185
Status: resolved
Priority: 0/
Queue: SQL-Statement

People
Owner: JZUCKER [...] cpan.org
Requestors: spam [...] punch.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: missing self on sub group_ands
the sub group_ands is not a method, and is called in non_parens_search like this: ($str,$and_preds) = group_ands($str); This should be $self->group_ands($str); Also group_ands should be changed to: sub group_ands{ my $self = shift; my $str = shift; ... return $self->group_ands($str,$and_preds); This will allow people to subclass SQL::Parser more easliy
Show quoted text
> This should be $self->group_ands($str);
... Show quoted text
> This will allow people to subclass SQL::Parser more easliy
You are entirely correct. Dean Arnold rewrote it to work as a method rather than a function and added a couple of more feature to make subclassing easier. These will be available in the 1.10 release, you can try a prelease version at http://www.vpservices.com/jeff/programs/SQL-Statement-1.10.tar.gz. Thanks for your suggestions.