Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Devel-PPPort CPAN distribution.

Report information
The Basics
Id: 81796
Status: resolved
Priority: 0/
Queue: Devel-PPPort

People
Owner: MHX [...] cpan.org
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] my $_ is deprecated
my $_ is now deprecated in bleadperl. See <https://rt.perl.org/rt3//Public/Bug/Display.html?id=114020> and <https://rt.perl.org/rt3//Public/Bug/Display.html?id=75598>, particularly the explanation at <https://rt.perl.org/rt3/Ticket/Display.html?id=75598#txn-1175682> and Ricardo’s decision at <https://rt.perl.org/rt3/Ticket/Display.html?id=75598#txn-1175872>. The attached patch suppresses the warning in the tests.
Subject: open_QfhHbKch.txt
diff --git a/parts/inc/misc b/parts/inc/misc index 59c326a..e41c673 100644 --- a/parts/inc/misc +++ b/parts/inc/misc @@ -496,6 +496,7 @@ ok(&Devel::PPPort::UNDERBAR(), "Fred"); if ($] >= 5.009002) { eval q{ + no warnings "deprecated"; my $_ = "Tony"; ok(&Devel::PPPort::DEFSV(), "Fred"); ok(&Devel::PPPort::UNDERBAR(), "Tony"); diff --git a/cpan/Devel-PPPort/t/misc.t b/cpan/Devel-PPPort/t/misc.t index 9dcc565..f74a9df 100644 --- a/t/misc.t +++ b/t/misc.t @@ -59,6 +59,7 @@ ok(&Devel::PPPort::UNDERBAR(), "Fred"); if ($] >= 5.009002) { eval q{ + no warnings "deprecated"; my $_ = "Tony"; ok(&Devel::PPPort::DEFSV(), "Fred"); ok(&Devel::PPPort::UNDERBAR(), "Tony");
From: nick [...] ccl4.org
On Sat Dec 08 09:59:52 2012, SPROUT wrote: Show quoted text
> my $_ is now deprecated in bleadperl.
This has been changed to an experimental feature. Hence the route to suppress the warning has changed. Patch from blead attached. Nicholas Clark
Subject: e5b2cbd045b1a66adca6bba76eb0711b3d146911

Message body not shown because it is not plain text.

On Thu Feb 28 05:04:49 2013, nick@ccl4.org wrote: Show quoted text
> On Sat Dec 08 09:59:52 2012, SPROUT wrote:
> > my $_ is now deprecated in bleadperl.
> > This has been changed to an experimental feature. Hence the route to > suppress the warning has changed. > > Patch from blead attached. > > Nicholas Clark
Thanks, applied. I actually need both suppressions, as D::PPP could be installed with a version where my $_ is deprecated. Marcus
Just adding a note to say that it would be convenient for a new CPAN release to be rolled before the next Perl is released on 20th August to get things back in sync.
On Wed Jul 31 03:27:13 2013, SHAY wrote: Show quoted text
> Just adding a note to say that it would be convenient for a new CPAN > release to be rolled before the next Perl is released on 20th August > to get things back in sync.
BTW, there is another text fix at <http://perl5.git.perl.org/perl.git/commitdiff/90b0dc0e2>.
On Mon Aug 12 15:49:02 2013, SPROUT wrote: Show quoted text
> On Wed Jul 31 03:27:13 2013, SHAY wrote:
> > Just adding a note to say that it would be convenient for a new CPAN > > release to be rolled before the next Perl is released on 20th August > > to get things back in sync.
> > BTW, there is another text fix at > <http://perl5.git.perl.org/perl.git/commitdiff/90b0dc0e2>.
And here it is as an attachment.
Subject: the other test fix.txt
diff --git a/parts/inc/SvPV b/parts/inc/SvPV index a7aace7..4894c3c 100644 --- a/parts/inc/SvPV +++ b/parts/inc/SvPV @@ -510,6 +510,7 @@ $mhx = 42; ok(&Devel::PPPort::SvPV_nomg_const($mhx), 2); $mhx = 42; ok(&Devel::PPPort::SvPV_nomg_const_nolen($mhx), 0); my $str = ""; +&Devel::PPPort::SvPV_force($str); my($s2, $before, $after) = &Devel::PPPort::SvPV_renew($str, 81, "x"x80); ok($str, "x"x80); ok($s2, "x"x80); @@ -517,6 +518,7 @@ ok($before < 81); ok($after, 81); $str = "x"x400; +&Devel::PPPort::SvPV_force($str); ($s2, $before, $after) = &Devel::PPPort::SvPV_renew($str, 41, "x"x40); ok($str, "x"x40); ok($s2, "x"x40); diff --git a/t/SvPV.t b/t/SvPV.t index 63c7d72..025c461 100644 --- a/t/SvPV.t +++ b/t/SvPV.t @@ -101,6 +101,7 @@ $mhx = 42; ok(&Devel::PPPort::SvPV_nomg_const($mhx), 2); $mhx = 42; ok(&Devel::PPPort::SvPV_nomg_const_nolen($mhx), 0); my $str = ""; +&Devel::PPPort::SvPV_force($str); my($s2, $before, $after) = &Devel::PPPort::SvPV_renew($str, 81, "x"x80); ok($str, "x"x80); ok($s2, "x"x80); @@ -108,6 +109,7 @@ ok($before < 81); ok($after, 81); $str = "x"x400; +&Devel::PPPort::SvPV_force($str); ($s2, $before, $after) = &Devel::PPPort::SvPV_renew($str, 41, "x"x40); ok($str, "x"x40); ok($s2, "x"x40);
On Wed Jul 31 03:27:13 2013, SHAY wrote: Show quoted text
> Just adding a note to say that it would be convenient for a new CPAN > release to be rolled before the next Perl is released on 20th August > to get things back in sync.
Thanks, I'll try to push an update this weekend.
This is part of the 3.21 release that just hit CPAN. Marcus