Bug #81757 for Net-DNS-ZoneFile-Fast: Net::DNS::RR::new_from

Thu Dec 06 19:57:51 2012 amiribarksdale [...] gmail.com - Ticket created

Subject:

Net::DNS::RR::new_from_hash is gone

With Net::DNS> 0.69, this module fails to call a method Net::DNS::RR::new_from_hash, because it has been deleted!

Fri Dec 07 11:35:29 2012 rsrchboy [...] cpan.org - Cc RSRCHBOY added

Fri Dec 28 05:57:48 2012 rwfranks [...] acm.org - Correspondence added

From:

rwfranks [...] acm.org

On Thu Dec 06 19:57:51 2012, AMIRI wrote: Show quoted text

> With Net::DNS> 0.69, this module fails to call a method > Net::DNS::RR::new_from_hash, because it has been deleted!

new_from_hash() is not, and never has been, part of the published API. *** /home/rwf/src/Net-DNS-ZoneFile-Fast-1.17/Fast.pm 2012-09-24 22:43:37.000000000 +0100 --- ./Fast.pm 2012-12-28 10:51:20.842453323 +0000 *************** *** 198,205 **** $z->{mbox} = uc $z->{mbox} if defined $z->{mbox}; $z->{txtdname} = uc $z->{txtdname} if defined $z->{txtdname}; } ! my $newrec = ! Net::DNS::RR->new_from_hash(%$z); if ($newrec->{'type'} eq 'DNSKEY') { if (ref($newrec) ne 'Net::DNS::RR::DNSKEY') { --- 198,204 ---- $z->{mbox} = uc $z->{mbox} if defined $z->{mbox}; $z->{txtdname} = uc $z->{txtdname} if defined $z->{txtdname}; } ! my $newrec = Net::DNS::RR->new(%$z); if ($newrec->{'type'} eq 'DNSKEY') { if (ref($newrec) ne 'Net::DNS::RR::DNSKEY') {

Fri Dec 28 05:57:49 2012 The RT System itself - Status changed from 'new' to 'open'

Wed Jan 02 13:51:49 2013 wjhns117 [...] hardakers.net - Correspondence added

I think the original author used it to avoid one unnecessary function in the stack. I've changed it for the next release to use new().

Wed Jan 02 13:52:24 2013 wjhns117 [...] hardakers.net - Status changed from 'open' to 'resolved'

Wed Jan 02 13:52:25 2013 wjhns117 [...] hardakers.net - Given to HARDAKER

Wed Jan 02 15:38:58 2013 rsrchboy [...] cpan.org - Correspondence added

CC:	amiribarksdale [...] gmail.com
Subject:	Re: [rt.cpan.org #81757] Net::DNS::RR::new_from_hash is gone
Date:	Wed, 2 Jan 2013 14:38:28 -0600
To:	bug-Net-DNS-ZoneFile-Fast [...] rt.cpan.org
From:	Chris Weyl <rsrchboy [...] cpan.org>

On Wed, Jan 2, 2013 at 12:51 PM, Wes Hardaker via RT < bug-Net-DNS-ZoneFile-Fast@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=81757 > > > I think the original author used it to avoid one unnecessary function in > the stack. I've changed it for the next release to use new(). >

Thanks! :) -Chris -- Chris Weyl Ex astris, scientia

Wed Jan 02 15:38:59 2013 The RT System itself - Status changed from 'resolved' to 'open'

Wed Mar 06 14:07:56 2013 wjhns117 [...] hardakers.net - Status changed from 'open' to 'resolved'

Bug #81757 for Net-DNS-ZoneFile-Fast: Net::DNS::RR::new_from_hash is gone