Bug #81729 for AnyEvent-RabbitMQ: could you include my simple patch to support SSL?

Wed Dec 05 16:52:26 2012 julio [...] hawaii.edu - Ticket created

Subject:	could you include my simple patch to support SSL?
Date:	Wed, 5 Dec 2012 11:52:16 -1000
To:	bug-AnyEvent-RabbitMQ [...] rt.cpan.org
From:	Julio Polo <julio [...] hawaii.edu>

I noticed that AnyEvent::RabbitMQ has been forked, so maybe I will now get an answer from the person who took over (bobtfish). I was wondering if you could include this simple patch to enable SSL: https://www.hawaii.edu/bwiki/download/attachments/230228663/RabbitMQ-tls.patch I've received several inquiries about making it official. The patch allows me to do add a 'tls' option when connecting: $ar = AnyEvent::RabbitMQ->new->load_xml_spec()->connect ( 'tls' => 1, 'host' => ... ) And maybe you can also include a patch similar to this one: https://www.hawaii.edu/bwiki/download/attachments/230228663/RabbitMQ-Channel-args.patch which I'm currently using to pass values to the header to make messages persistent: $channel->publish ( exchange => $exchange_name, routing_key => $routing_key, body => $body, # this requires our patch to AnyEvent::RabbitMQ::Channel.pm header => { 'delivery_mode' => 2 }, # make messages persistent ); If you want more context for this, see our download page: https://www.hawaii.edu/bwiki/display/UHIAM/Download Thanks! Julio Polo Identity and Access Management Information Technology Services University of Hawaii julio.polo@hawaii.edu

Mon Feb 25 07:55:43 2013 bobtfish [...] bobtfish.net - Correspondence added

I've merged this change as commit #4116b9f, many thanks for the patch, and apologies for the delay.

Mon Feb 25 07:55:44 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 25 07:55:44 2013 bobtfish [...] bobtfish.net - Status changed from 'open' to 'resolved'

Mon Feb 25 20:38:00 2013 julio [...] hawaii.edu - Correspondence added

Subject:	Re: [rt.cpan.org #81729] could you include my simple patch to support SSL?
Date:	Mon, 25 Feb 2013 15:37:50 -1000
To:	bug-AnyEvent-RabbitMQ [...] rt.cpan.org
From:	Julio Polo <julio [...] hawaii.edu>

Thanks, do you have any plans for including the other patch I mentioned in that same request, the one that allows us to pass values to the header: https://www.hawaii.edu/bwiki/download/attachments/230228663/RabbitMQ-Channel-args.patch which I'm currently using to pass values to the header to make messages persistent: $channel->publish ( exchange => $exchange_name, routing_key => $routing_key, body => $body, # this requires our patch to AnyEvent::RabbitMQ::Channel.pm header => { 'delivery_mode' => 2 }, # make messages persistent ); Julio Polo University of Hawaii On Mon, Feb 25, 2013 at 2:55 AM, Tomas Doran via RT <bug-AnyEvent-RabbitMQ@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=81729 > > > I've merged this change as commit #4116b9f, many thanks for the patch, > and apologies for the delay.

Mon Feb 25 20:38:01 2013 The RT System itself - Status changed from 'resolved' to 'open'

Wed Jun 03 16:59:23 2020 DLAMBLEY [...] cpan.org - Correspondence added

On Mon Feb 25 20:38:00 2013, julio@hawaii.edu wrote: Show quoted text

> Thanks, do you have any plans for including the other patch I > mentioned in that same request, the one that allows us to pass values > to the header: > > https://www.hawaii.edu/bwiki/download/attachments/230228663/RabbitMQ- > Channel-args.patch > > which I'm currently using to pass values to the header to make > messages persistent: > > $channel->publish > ( > exchange => $exchange_name, > routing_key => $routing_key, > body => $body, > # this requires our patch to AnyEvent::RabbitMQ::Channel.pm > header => { 'delivery_mode' => 2 }, # make messages > persistent > );

Thank you for this patch too. I've created a PR to merge it in https://github.com/bobtfish/AnyEvent-RabbitMQ/pull/32 However, I have just been looking at it, and I don't think you need the patch to get the functionality you need. We place %$args at the bottom of the data structure already, so you should be able to override any of the parameters, the same as with your patch. I'll close this for now. Please let me know and reopen if there is something that I have missed. THank you for your contribution! Best regards, Dave

Wed Jun 03 16:59:25 2020 DLAMBLEY [...] cpan.org - Taken

Wed Jun 03 16:59:44 2020 DLAMBLEY [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Jun 03 16:59:45 2020 DLAMBLEY [...] cpan.org - Fixed in 1.21 added

Wed Jun 03 19:51:59 2020 julio [...] hawaii.edu - Correspondence added

Subject:	Re: [rt.cpan.org #81729] could you include my simple patch to support SSL?
Date:	Wed, 3 Jun 2020 13:51:36 -1000
To:	bug-AnyEvent-RabbitMQ [...] rt.cpan.org
From:	Julio Polo <julio [...] hawaii.edu>

You are right. I tested without my patch and the delivery_mode I passed was indeed set because of %$args. Thanks! -julio On Wed, Jun 3, 2020 at 10:59 AM Dave Lambley via RT < bug-AnyEvent-RabbitMQ@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=81729 > > > On Mon Feb 25 20:38:00 2013, julio@hawaii.edu wrote:

> > Thanks, do you have any plans for including the other patch I > > mentioned in that same request, the one that allows us to pass values > > to the header: > > > > https://www.hawaii.edu/bwiki/download/attachments/230228663/RabbitMQ- > > Channel-args.patch > > > > which I'm currently using to pass values to the header to make > > messages persistent: > > > > $channel->publish > > ( > > exchange => $exchange_name, > > routing_key => $routing_key, > > body => $body, > > # this requires our patch to AnyEvent::RabbitMQ::Channel.pm > > header => { 'delivery_mode' => 2 }, # make messages > > persistent > > );

> > Thank you for this patch too. I've created a PR to merge it in > https://github.com/bobtfish/AnyEvent-RabbitMQ/pull/32 > > However, I have just been looking at it, and I don't think you need the > patch to get the functionality you need. We place %$args at the bottom of > the data structure already, so you should be able to override any of the > parameters, the same as with your patch. > > I'll close this for now. Please let me know and reopen if there is > something that I have missed. THank you for your contribution! > > Best regards, > Dave >