Skip Menu |

This queue is for tickets about the MooseX-Storage CPAN distribution.

Report information
The Basics
Id: 81695
Status: resolved
Priority: 0/
Queue: MooseX-Storage

People
Owner: Nobody in particular
Requestors: garu [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Test failures due to hash randomization in 5.17.6
Hey guys! looks like perl's new hash randomization breaks some of the tests in MooseX::Storage, in particular the ones in t/011_basic_json_w_utf8.t: # Failed test '... got the right JSON' # at t/011_basic_json_w_utf8.t line 48. # got: '{"utf8_string":"ネットスーパー (Internet Shopping)","__CLASS__":"Foo"}' # expected: '{"__CLASS__":"Foo","utf8_string":"ネットスーパー (Internet Shopping)"}' # Failed test '... got the right JSON' # at t/011_basic_json_w_utf8.t line 59. # got: '{"utf8_string":"ネットスーパー (Internet Shopping)","__CLASS__":"Foo"}' # expected: '{"__CLASS__":"Foo","utf8_string":"ネットスーパー (Internet Shopping)"}' # Failed test '... got the right JSON' # at t/011_basic_json_w_utf8.t line 93. # got: '{"utf8_string":"ネットスーパー (Internet Shopping)","__CLASS__":"Foo"}' # expected: '{"__CLASS__":"Foo","utf8_string":"ネットスーパー (Internet Shopping)"}' # Looks like you failed 3 tests of 16. t/011_basic_json_w_utf8.t ............... Dubious, test returned 3 (wstat 768, 0x300) Failed 3/16 subtests Looks like those tests rely on hash key ordering without using sort, but I'm just saying this from cpan's shell output, as I haven't actually looked at the source. Hope this helps! Looking forward to a new release :)
On 2012-12-04 08:54:16, GARU wrote: Show quoted text
> Hey guys! > > looks like perl's new hash randomization breaks some of the tests in > MooseX::Storage, in particular the ones in t/011_basic_json_w_utf8.t:
I've fixed the tests (and the code, so the test fix actually works!), and pushed it to git, git://git.moose.perl.org/MooseX-Storage.git hash_order_rt81695 Show quoted text
> Hope this helps! Looking forward to a new release :)
I'm chasing the maintainers for that now.
This is now fixed, thanks for the bug report!