Bug #81645 for XML-Hash-LX: Test failures due to hash randomisation in perl 5.17.6

Dne Ne 02.pro.2012 08:10:17, ANDK napsal(a): Show quoted text
Attached patch fixes the test. -- Petr

From 19c3c8bbb1646dc5bfe7f0d3df5efb3ba58ada80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Mon, 9 Jun 2014 17:41:32 +0200 Subject: [PATCH] Fix unpredictable order at 'empty attr' test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RT#81645 Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/01-conv.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/01-conv.t b/t/01-conv.t index f7b06c5..30f24dc 100644 --- a/t/01-conv.t +++ b/t/01-conv.t @@ -297,7 +297,7 @@ our $xml = qq{<?xml version="1.0" encoding="utf-8"?>\n}; } { is - $data = hash2xml( { node => { -attr => undef, '#cdata' => undef, '/' => undef, x=>undef } }, cdata => '#cdata', comm => '/' ), + $data = hash2xml( { node => [ { -attr => undef }, { '#cdata' => undef }, { '/' => undef }, { x=>undef } ] }, cdata => '#cdata', comm => '/' ), qq{$xml<node attr=""><!----><x/></node>\n}, 'empty attr', ; -- 1.9.3

On Sun Dec 02 08:10:17 2012, ANDK wrote: Show quoted text
Today I attempted to install this distribution on FreeBSD-11.1 against perl-5.29.2 using 'cpanm' as the installer. I got test failures in the same test file as reported by Andreas Koenig in 2012. Since, as Andreas noted, these failures are due to hash randomization, it is sometimes possible to run the test and get a PASS. Please see attachment. Please consider patch already proposed. Thank you very much. Jim Keenan

{ author => "MONS", dist => "XML-Hash-LX", distname => "XML-Hash-LX-0.0603", distversion => 0.0603, grade => "FAIL", prereqs => undef, test_output => [ "Building and testing XML-Hash-LX-0.0603", "cp lib/XML/Hash/LX.pm blib/lib/XML/Hash/LX.pm", "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/var/tad/testing/perl-5.29.2/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"-e\" \"undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')\" t/00-load.t t/01-conv.t t/02-inject.t t/03-no-inject.t t/pod-coverage.t t/pod.t", "# Testing XML::Hash::LX 0.0603, Perl 5.029002, /usr/home/jkeenan/var/tad/testing/perl-5.29.2/bin/perl", "t/00-load.t ....... ok", "", "# Failed test 'empty attr'", "# at t/01-conv.t line 299.", "# got: '<?xml version=\"1.0\" encoding=\"utf-8\"?>", "# <node attr=\"\"><x/><!----></node>", "# '", "# expected: '<?xml version=\"1.0\" encoding=\"utf-8\"?>", "# <node attr=\"\"><!----><x/></node>", "# '", "# Looks like you failed 1 test of 32.", "t/01-conv.t ....... ", "Dubious, test returned 1 (wstat 256, 0x100)", "Failed 1/32 subtests ", "t/02-inject.t ..... ok", "t/03-no-inject.t .. ok", "t/pod-coverage.t .. ok", "t/pod.t ........... ok", "", "Test Summary Report", "-------------------", "t/01-conv.t (Wstat: 256 Tests: 32 Failed: 1)", " Failed test: 30", " Non-zero exit status: 1", "Files=6, Tests=44, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.52 cusr 0.29 csys = 0.84 CPU)", "Result: FAIL", ], via => "App::cpanminus::reporter 0.17 (1.7044)", }