Bug #81623 for Class-Generate: Test failures due to hash randomisation in perl 5.17.6

Sat Dec 01 23:22:59 2012 ANDK [...] cpan.org - Ticket created

Subject:

Test failures due to hash randomisation in perl 5.17.6

Since bleadperl v5.17.5-518-g7dc8663 your tests are failing frequently. That commit introduced hash key randomization and it seems at least the test t/protected_members.t is hit by that. Find a sample fail report at: http://www.cpantesters.org/cpan/report/f9b54116-31d9-11e2-9b50-0ed5a290f8f5 You can read more about the change at http://perl5.git.perl.org/perl.git/commit/7dc8663964c66a698d31bbdc8e8abed69bddeec3 or at http://www.perlmonks.org/?node_id=1005122 You may have to run the test several times until the randomization causes a fail. HTH&&Thanks&&Regards,

Tue Jan 21 07:41:33 2014 SHLOMIF [...] cpan.org - Correspondence added

Subject:

[PATCH] Patch to fix the problem.

Here is a patch to fix the problem courtesy of my work on the Mageia Linux distribution. Apply with patch -p0. Regards, -- Shlomi Fish

Subject:

Class-Generate-fix-tests-in-perl-5.18.x.patch

--- t/protected_members.t.ORIG 2014-01-21 14:30:15.599866360 +0200 +++ t/protected_members.t 2014-01-21 14:30:23.199787242 +0200 @@ -85,7 +85,7 @@ '&set_asub' => '$prot_amem[$_[0]] = $_[1];', '&get_sub' => <<'EOS' { - my $hmem = '{' . join(',', map "$_=>$prot_hmem{$_}", keys %prot_hmem) . '}'; + my $hmem = '{' . join(',', map "$_=>$prot_hmem{$_}", sort { $a cmp $b } keys %prot_hmem) . '}'; my $amem = '[' . join(',', @prot_amem) . ']'; return "amem = $amem; hmem = $hmem"; }

Tue Jan 21 07:41:33 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Jan 22 10:35:03 2014 SHLOMIF [...] cpan.org - Correspondence added

On Tue Jan 21 07:41:33 2014, SHLOMIF wrote: Show quoted text

> Here is a patch to fix the problem courtesy of my work on the Mageia > Linux distribution. > > Apply with patch -p0. > > Regards, > > -- Shlomi Fish

Patch applied in 1.12. Closing this ticket - tests are OK now. Regards, — Shlomi Fish

Wed Jan 22 10:35:04 2014 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Jan 22 10:35:05 2014 SHLOMIF [...] cpan.org - Fixed in 1.12 added