Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Text-vCard CPAN distribution.

Report information
The Basics
Id: 81502
Status: resolved
Priority: 0/
Queue: Text-vCard

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.12
Fixed in: (no value)



Subject: Test failures due to hash randomisation in perl 5.17.6
Since bleadperl v5.17.5-518-g7dc8663 your tests are failing. That commit introduced hash key randomization and it seems at least the test t/05-export.t is hit by that. Find a sample fail report at: http://www.cpantesters.org/cpan/report/e3cd55aa-3157-11e2- b12b-0cb8a290f8f5 You can read more about the commit at http://perl5.git.perl.org/perl .git/commit/7dc8663964c66a698d 31bbdc8e8abed69bddeec3 HTH&&Thanks&&Regards,
Hi I've logged an issue and a diff for the fix in github, but I couldn't see how to add a file, so I included the diff in situ. Unfortunately, github reformatted it, so the diff is attached. Cheers Ron
Subject: Text-vCard-2.12.diff
diff -ur Text-vCard-2.12.bak/lib/Text/vCard/Node.pm Text-vCard-2.12/lib/Text/vCard/Node.pm --- Text-vCard-2.12.bak/lib/Text/vCard/Node.pm 2012-12-20 13:40:59.000000000 +1100 +++ Text-vCard-2.12/lib/Text/vCard/Node.pm 2012-12-20 13:41:24.000000000 +1100 @@ -222,7 +222,7 @@ my $self = shift; my @types; return undef unless defined $self->{params}; - @types = keys %{ $self->{params} }; + @types = sort keys %{ $self->{params} }; return wantarray ? @types : \@types; } Only in Text-vCard-2.12: MYMETA.json Only in Text-vCard-2.12: MYMETA.yml diff -ur Text-vCard-2.12.bak/t/05-export.t Text-vCard-2.12/t/05-export.t --- Text-vCard-2.12.bak/t/05-export.t 2012-12-20 13:41:08.000000000 +1100 +++ Text-vCard-2.12/t/05-export.t 2012-12-20 13:41:35.000000000 +1100 @@ -21,7 +21,7 @@ 'TEL;pref;home:020 666 6666', 'TEL;cell:0777 777 7777', 'item2.ADR;work:;;Test Road;Test City;;Test Postcode;Test Country', - 'item1.ADR;TYPE=pref,home:;;Pref Test Road;Pref Test City;;Pref Test Postcode;Pref Test Country', + 'item1.ADR;TYPE=home,pref:;;Pref Test Road;Pref Test City;;Pref Test Postcode;Pref Test Country', 'VERSION:3.0', 'FN:T-firstname T-surname', 'END:VCARD', @@ -49,16 +49,16 @@ 'item1.X-ABADR;charset=utf-8:uk', 'item2.X-ABADR;charset=utf-8:uk', 'N;charset=utf-8:T-surname;T-first;;;', - 'TEL;charset=utf-8;TYPE=pref,home:020 666 6666', + 'TEL;charset=utf-8;TYPE=home,pref:020 666 6666', 'TEL;charset=utf-8;TYPE=cell:0777 777 7777', 'item2.ADR;charset=utf-8;TYPE=work:;;Test Road;Test City;;Test Postcode;Test Country', - 'item1.ADR;charset=utf-8;TYPE=pref,home:;;Pref Test Road;Pref Test City;;Pref Test Postcode;Pref Test Country', + 'item1.ADR;charset=utf-8;TYPE=home,pref:;;Pref Test Road;Pref Test City;;Pref Test Postcode;Pref Test Country', 'VERSION;charset=utf-8:3.0', 'FN;charset=utf-8:T-firstname T-surname', 'END:VCARD', ); @lines = split( "\r\n", $adbk->export() ); -is_deeply( \@lines, \@data, +is_deeply( [sort @lines], [sort @data], 'set_encoding() - returned data matched that expected' ); #is_deeply(\@lines,\@data,'export() - returned data matched that expected');
Thanks for reporting - version 2.13 on it's way to CPAN