Skip Menu |

This queue is for tickets about the Perl-Critic-Pulp CPAN distribution.

Report information
The Basics
Id: 81390
Status: resolved
Priority: 0/
Queue: Perl-Critic-Pulp

People
Owner: Nobody in particular
Requestors: MOREGAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 74
Fixed in: (no value)



Subject: ValuesAndExpressions::ProhibitEmptyCommas false positive
echo 'my $x = [ { %defaults, a => "b"}, {} ]' | perlcritic --single ValuesAndExpressions::ProhibitEmptyCommas Empty comma operator at line 1, column 33. (no explanation). (Severity: 2) and: echo 'my $x = [ { 1, 2, a => "b"}, {} ]' | perlcritic --single ValuesAndExpressions::ProhibitEmptyCommas Empty comma operator at line 1, column 28. (no explanation). (Severity: 2) and: echo 'my $x = [ { 1, 2, a => "b"}, ]' | perlcritic --single ValuesAndExpressions::ProhibitEmptyCommas Empty comma operator at line 1, column 28. (no explanation). (Severity: 2) but as expected: echo 'my $x = [ { a => "b"}, ]' | perlcritic --single ValuesAndExpressions::ProhibitEmptyCommas source OK
Thanks. I put a couple of lines in version 75 to notice this. I'll have to see if there's something more general related to how constructors and commas come out of ppi.