Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 81100
Status: rejected
Priority: 0/
Queue: Dist-Zilla
People
Owner: Nobody in particular
Requestors: hanenkamp [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sat Nov 10 17:35:33 2012 hanenkamp [...] cpan.org - Ticket created
Subject: PkgVersion inserts $VERSION above use strict
If you want to use the standard PerlCritic tests that make sure that use strict is used, you can't if you use PkgVersion because it inserts the package version immediately below package and before use strict. Seems like it makes sense for PkgVersion to skip use strict and use warnings as well as the package statement.
  Thu Jul 02 11:29:59 2015 ether [...] cpan.org - Correspondence added
On 2012-11-10 14:35:33, HANENKAMP wrote: Show quoted text
> If you want to use the standard PerlCritic tests that make sure that > use strict is used, you can't if > you use PkgVersion because it inserts the package version immediately > below package and > before use strict. > > Seems like it makes sense for PkgVersion to skip use strict and use > warnings as well as the > package statement.
This is what I do: use strict; use warnings; package Foo; ...so any inserted code always appears after strict and warnings.
  Thu Jul 02 11:30:00 2015 The RT System itself - Status changed from 'new' to 'open'
  Sun Apr 03 10:09:13 2016 rjbs [...] cpan.org - Correspondence added
I'm With Ether. Also, I'm tempted to say that I'd take a patch, but I think that PkgVersion might be complex enough as it is, and maybe could use a big refactor to make its sub-behaviors pluggable. Sorry for taking so long to reply! -- rjbs
  Sun Apr 03 10:09:14 2016 rjbs [...] cpan.org - Status changed from 'open' to 'rejected'