* chernomyrdin@gmail.com via RT (bug-XML-Compile-WSS-Signature@rt.cpan.org) [121109 09:26]:
Show quoted text
Ok, please do not release the current release, start with the next.
Show quoted text> Firest: I write about small problem with debianize XML-Compile* packages:
> You use Digest::SHA1, but in debian and ubuntu use Digest::SHA (newer and
> performace version).
> When I packaging I ,ake small patches for replace Digest::SHA1 into
> Digest::SHA.
No, please. Do not give yourself the freedom to mess with the authors
choice. Imagine: I try to fix all reported bugs imediately... when my
released module has been modified, I may spend days investigation the
bug introduced by someone else.
I have encountered "smart" packagers before, I hate it. Please do
send me bug-reports (very welcome, thanks in advance) but do *not*
change my code.
Show quoted text> Second: in lib/XML/Compile/WSS/Signature.pm sub digester using
> Digest->new($algo), and $algo = SHA1, but for module Digest, better using
> SHA-1 for this argument will be try load Digest::SHA if exist, on fail load
> Digest::SHA1
I can not help it when Digest is not smarter than that. Help that
author to improve his logic.
I will not change my code: my module is agnostic about the supported
digest algorithm. There are many, I do not want to maintain a
translation table just to make Digest to work a little more efficient
(probably unmeasurable performance improvement)
--
Regards,
MarkOv
------------------------------------------------------------------------
Mark Overmeer MSc MARKOV Solutions
Mark@Overmeer.net solutions@overmeer.net
http://Mark.Overmeer.net http://solutions.overmeer.net
RT for rt.cpan.org