Subject: | Rotating files not handled properly |
Date: | Fri, 9 Nov 2012 09:16:21 +1100 |
To: | "bug-File-Tail-Multi [...] rt.cpan.org" <bug-File-Tail-Multi [...] rt.cpan.org> |
From: | "Danny Blazejczak (AU)" <danny.blazejczak [...] dimensiondata.com> |
Hi,
I noticed that your module has some issue with rotating files. I am testing this on Red Hat 4, ext3 file system.
The way that the log files are rotating goes like:
# test.log is the test files
mv test.log test.log.1
The issue seems that upon file rotation, the size from the old file (test.log.1) is maintained (in app.lastrun), and logging seems to block until the size of the rotated file (test.log.1) is reached, missing the top part of the latest file.
I made patches to fix this, and tested those successfully. I doubt it is a perfect patch, but it works. I am basically comparing the inode, and when it changes close the rotated file (test.log.1), and reset the position to 0.
Attached is the updated Module and a patch file, with the changes I made.
Thanks,
Danny
Message body is not shown because sender requested not to inline it.
Message body is not shown because sender requested not to inline it.